From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] shell: Use $LTP_TIMEOUT_MUL also in retry functions
Date: Fri, 19 Jul 2019 11:01:33 +0200 [thread overview]
Message-ID: <20190719090133.GB30204@dell5510> (raw)
In-Reply-To: <CAEemH2etXFYC-R1znaKCm_WyQDvAqT0fZafKLJGzTUU6uMEN1A@mail.gmail.com>
Hi Li,
> > + That page is too long and without table of contents (not easy to
> > navigate in it; I tried to add TOC, but without success). Maybe adding
> > TOC or split the page to 3: 1) general info 2) C API 3) shell API would
> > help. WDYT?
> Personally, I think adding TOC may be a better choice, since we don't have
> the whole picture for the guidelines and usually hard to navigate in it.
> To split the guideline that probably leads to the new LTP-user to read more
> document pages. That's an annoying thing for me at least :).
Agree. I'll give TOC next try sooner or later :).
...
> > _tst_setup_timer()
> > {
> > - LTP_TIMEOUT_MUL=${LTP_TIMEOUT_MUL:-1}
> > -
> > local sec=$((300 * LTP_TIMEOUT_MUL))
> Maybe we need to check if the LTP_TIMEOUT_MUL is valid(>1) as what we do
> for C API?
Correct, sorry for omitting that => v3 needed.
Kind regards,
Petr
prev parent reply other threads:[~2019-07-19 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 8:39 [LTP] [PATCH 1/2] shell: Use $LTP_TIMEOUT_MUL also in retry functions Petr Vorel
2019-07-18 8:39 ` [LTP] [PATCH 2/2] c: " Petr Vorel
2019-07-19 5:02 ` Li Wang
2019-07-19 9:15 ` Petr Vorel
2019-07-19 4:56 ` [LTP] [PATCH 1/2] shell: " Li Wang
2019-07-19 9:01 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719090133.GB30204@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox