From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH] syscalls: Remove getcontext01
Date: Mon, 22 Jul 2019 11:14:03 +0200 [thread overview]
Message-ID: <20190722091403.GA12237@dell5510> (raw)
In-Reply-To: <20190722085215.GA10580@rei.lan>
Hi Cyril,
> > According to man getcontext(3) getcontext was this function from
> > POSIX.1-2001 (SUSv2) removed from POSIX.1-2008 (SUSv3).
> Being deprecated from POSIX is never a reason to remove tests as far as
> the API is exposed to userspace it should be tested.
OK, thanks for a clarification. I thought that, but wasn't sure. That's
why this RFC. Agree with the point + it's still in current glibc.
BTW Maybe it'd be good to write down this policy + write which glibc versions
we support, which would answer whether some functionality can be removed in
given point (we describe goals and mention glibc in old document doc/ltp-howto.{txt,lyx},
but IMHO we should update this document remove lyx version and add it to wiki).
> > Given that the test was just a smoke tests (doing nothing) and we don't
> > test other functions from this family ({set,swap,make}context) remove it.
> I wouldn't say it's doing nothing, it asserts that call to getcontext()
> returns 0, which is very basic but still a valid test.
Right :).
> What is the real motivation for this removal?
Looking over the weekend on tests which does not compile on musl
(which does not include deprecated functionality). I'll rewrite the test into
new API and add autotools check.
Kind regards,
Petr
next prev parent reply other threads:[~2019-07-22 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 8:33 [LTP] [RFC PATCH] syscalls: Remove getcontext01 Petr Vorel
2019-07-22 8:44 ` Xiao Yang
2019-07-22 9:18 ` Petr Vorel
2019-07-22 8:52 ` Cyril Hrubis
2019-07-22 9:14 ` Petr Vorel [this message]
2019-07-22 9:18 ` Cyril Hrubis
2019-07-22 9:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722091403.GA12237@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox