From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Mon, 22 Jul 2019 11:14:03 +0200 Subject: [LTP] [RFC PATCH] syscalls: Remove getcontext01 In-Reply-To: <20190722085215.GA10580@rei.lan> References: <20190722083356.10142-1-pvorel@suse.cz> <20190722085215.GA10580@rei.lan> Message-ID: <20190722091403.GA12237@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Cyril, > > According to man getcontext(3) getcontext was this function from > > POSIX.1-2001 (SUSv2) removed from POSIX.1-2008 (SUSv3). > Being deprecated from POSIX is never a reason to remove tests as far as > the API is exposed to userspace it should be tested. OK, thanks for a clarification. I thought that, but wasn't sure. That's why this RFC. Agree with the point + it's still in current glibc. BTW Maybe it'd be good to write down this policy + write which glibc versions we support, which would answer whether some functionality can be removed in given point (we describe goals and mention glibc in old document doc/ltp-howto.{txt,lyx}, but IMHO we should update this document remove lyx version and add it to wiki). > > Given that the test was just a smoke tests (doing nothing) and we don't > > test other functions from this family ({set,swap,make}context) remove it. > I wouldn't say it's doing nothing, it asserts that call to getcontext() > returns 0, which is very basic but still a valid test. Right :). > What is the real motivation for this removal? Looking over the weekend on tests which does not compile on musl (which does not include deprecated functionality). I'll rewrite the test into new API and add autotools check. Kind regards, Petr