public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH]syscalls/ioctl: bugfix for syscalls/ioctl/ioctl_ns05.c syscalls/ioctl/ioctl_ns06.c
@ 2019-07-22  2:29 Song Jian
  2019-07-22 12:54 ` Cyril Hrubis
  0 siblings, 1 reply; 2+ messages in thread
From: Song Jian @ 2019-07-22  2:29 UTC (permalink / raw)
  To: ltp

fix ioctl_ns05, ioctl_ns06 timeout.
signal() will return 0 if success, so it have no chance to equal
nr_wake=1, use another api to to repalce the current api to ensure that
nr_wark = 0.

Signed-off-by: Song Jian <songjian15@huawei.com>
---
 testcases/kernel/syscalls/ioctl/ioctl_ns05.c | 2 +-
 testcases/kernel/syscalls/ioctl/ioctl_ns06.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ns05.c b/testcases/kernel/syscalls/ioctl/ioctl_ns05.c
index a8dee07..8162012 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ns05.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ns05.c
@@ -80,7 +80,7 @@ static void run(void)
 	SAFE_CLOSE(my_fd);
 	SAFE_CLOSE(child_fd);
 	SAFE_CLOSE(parent_fd);
-	TST_CHECKPOINT_WAKE(0);
+	TST_CHECKPOINT_WAKE2(0, 0);
 }
 static struct tst_test test = {
diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ns06.c b/testcases/kernel/syscalls/ioctl/ioctl_ns06.c
index 805a0a0..d5010d0 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ns06.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ns06.c
@@ -75,7 +75,7 @@ static void run(void)
 	SAFE_CLOSE(my_fd);
 	SAFE_CLOSE(parent_fd);
 	SAFE_CLOSE(child_fd);
-	TST_CHECKPOINT_WAKE(0);
+	TST_CHECKPOINT_WAKE2(0, 0);
 }
 static struct tst_test test = {
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH]syscalls/ioctl: bugfix for syscalls/ioctl/ioctl_ns05.c syscalls/ioctl/ioctl_ns06.c
  2019-07-22  2:29 [LTP] [PATCH]syscalls/ioctl: bugfix for syscalls/ioctl/ioctl_ns05.c syscalls/ioctl/ioctl_ns06.c Song Jian
@ 2019-07-22 12:54 ` Cyril Hrubis
  0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2019-07-22 12:54 UTC (permalink / raw)
  To: ltp

Hi!
> fix ioctl_ns05, ioctl_ns06 timeout.
> signal() will return 0 if success, so it have no chance to equal
> nr_wake=1, use another api to to repalce the current api to ensure that
> nr_wark = 0.

I do not understand what is the problem here.

What do you mean by "signal() will return 0 if success" ?

The child has to be suspended in the futex until it's woken up so as far
as I can tell the checkpoint should be able to wake the child a the end
of the run() function.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-22 12:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-22  2:29 [LTP] [PATCH]syscalls/ioctl: bugfix for syscalls/ioctl/ioctl_ns05.c syscalls/ioctl/ioctl_ns06.c Song Jian
2019-07-22 12:54 ` Cyril Hrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox