From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 LTP]:Skip the test if "htop" is used.
Date: Thu, 25 Jul 2019 22:42:04 +0200 [thread overview]
Message-ID: <20190725204204.GA31486@x230> (raw)
In-Reply-To: <20190725013011.39342-1-siliangx.yu@intel.com>
Hi,
> From: "Yu,Siliang" <siliangx.yu@intel.com>
> In some distro, "htop" is used instead "top", which doesn't support '-b'. Skip the test if "htop" is used.
> ---
> .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
> index 18a11197e..ddb6abf95 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
> @@ -49,6 +49,11 @@ done
> LOOP_COUNT=1
> +realtop=$(which top | xargs realpath | xargs basename)
> +if [[ $realtop == "htop" ]] ; then
== is also a bashism, please use = (+ [[ ]] => [ ]).
> + tst_brkm TCONF "$realtop is used instead of top, Skip the test..."
> +fi
OK, v2. This looks better than v2, but I'd really use command version output
(top -v) to detect top vs. htop.
> +
> if [ $(get_present_cpus_num) -lt 2 ]; then
> tst_brkm TCONF "system doesn't have required CPU hotplug support"
> fi
Kind regards,
Petr
PS: please don't use ltp-request and ltp-owner, these aren't meant for patch
submission.
prev parent reply other threads:[~2019-07-25 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 1:30 [LTP] [PATCH v2 LTP] [PATCH v2 LTP]:Skip the test if "htop" is used Siliang, Yu
2019-07-25 20:42 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725204204.GA31486@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox