* [LTP] [PATCH v2 LTP] [PATCH v2 LTP]:Skip the test if "htop" is used.
@ 2019-07-25 1:30 Siliang, Yu
2019-07-25 20:42 ` [LTP] " Petr Vorel
0 siblings, 1 reply; 2+ messages in thread
From: Siliang, Yu @ 2019-07-25 1:30 UTC (permalink / raw)
To: ltp
From: "Yu,Siliang" <siliangx.yu@intel.com>
In some distro, "htop" is used instead "top", which doesn't support '-b'. Skip the test if "htop" is used.
---
.../kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
index 18a11197e..ddb6abf95 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
@@ -49,6 +49,11 @@ done
LOOP_COUNT=1
+realtop=$(which top | xargs realpath | xargs basename)
+if [[ $realtop == "htop" ]] ; then
+ tst_brkm TCONF "$realtop is used instead of top, Skip the test..."
+fi
+
if [ $(get_present_cpus_num) -lt 2 ]; then
tst_brkm TCONF "system doesn't have required CPU hotplug support"
fi
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH v2 LTP]:Skip the test if "htop" is used.
2019-07-25 1:30 [LTP] [PATCH v2 LTP] [PATCH v2 LTP]:Skip the test if "htop" is used Siliang, Yu
@ 2019-07-25 20:42 ` Petr Vorel
0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2019-07-25 20:42 UTC (permalink / raw)
To: ltp
Hi,
> From: "Yu,Siliang" <siliangx.yu@intel.com>
> In some distro, "htop" is used instead "top", which doesn't support '-b'. Skip the test if "htop" is used.
> ---
> .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
> index 18a11197e..ddb6abf95 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh
> @@ -49,6 +49,11 @@ done
> LOOP_COUNT=1
> +realtop=$(which top | xargs realpath | xargs basename)
> +if [[ $realtop == "htop" ]] ; then
== is also a bashism, please use = (+ [[ ]] => [ ]).
> + tst_brkm TCONF "$realtop is used instead of top, Skip the test..."
> +fi
OK, v2. This looks better than v2, but I'd really use command version output
(top -v) to detect top vs. htop.
> +
> if [ $(get_present_cpus_num) -lt 2 ]; then
> tst_brkm TCONF "system doesn't have required CPU hotplug support"
> fi
Kind regards,
Petr
PS: please don't use ltp-request and ltp-owner, these aren't meant for patch
submission.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-25 1:30 [LTP] [PATCH v2 LTP] [PATCH v2 LTP]:Skip the test if "htop" is used Siliang, Yu
2019-07-25 20:42 ` [LTP] " Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox