public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] move_pages12: handle errno EBUSY for madvise(..., MADV_SOFT_OFFLINE)
Date: Fri, 26 Jul 2019 15:31:24 +0200	[thread overview]
Message-ID: <20190726133124.GC28028@rei.lan> (raw)
In-Reply-To: <CAEemH2c96sB1ZA_vnTxSaBy-v=G_WnR58LX+Wt=Q8=UxO0dNtQ@mail.gmail.com>

Hi!
> -----system env-----
> # uname -r
> 5.3.0-rc1+
> 
> # numactl -H
> available: 4 nodes (0-3)
> node 0 cpus: 0 1 2 3 16 17 18 19
> node 0 size: 32171 MB
> node 0 free: 25358 MB
> node 1 cpus: 4 5 6 7 20 21 22 23
> node 1 size: 16125 MB
> node 1 free: 5565 MB
> node 2 cpus: 8 9 10 11 24 25 26 27
> node 2 size: 96765 MB
> node 2 free: 90646 MB
> node 3 cpus: 12 13 14 15 28 29 30 31
> node 3 size: 64482 MB
> node 3 free: 60820 MB
> node distances:
> node   0   1   2   3
>   0:  10  11  11  11
>   1:  11  10  11  11
>   2:  11  11  10  11
>   3:  11  11  11  10
> 
> So, maybe we have to re-evaluate this patch V2 and to figure out why
> the retry mmap() hitting SIGBUS fails.

One possibility would be that the numa_move_pages() triggers SIGBUS
while we do the usleep() before we attempt to retry the mmap(). In that
case the race was present in the test all the time but couldn't be
triggered because the window where the memory is unmapped was very
short. If that is the case we should as well set up a handler to SIGBUS
and ignore it as well.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2019-07-26 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25  3:37 [LTP] [PATCH v2] move_pages12: handle errno EBUSY for madvise(..., MADV_SOFT_OFFLINE) Li Wang
2019-07-26 12:12 ` Cyril Hrubis
2019-07-26 13:21   ` Li Wang
2019-07-26 13:31     ` Cyril Hrubis [this message]
2019-07-29  4:53       ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190726133124.GC28028@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox