public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/clock_gettime: Ported clock_gettime03.c to new API
Date: Mon, 29 Jul 2019 14:35:57 +0200	[thread overview]
Message-ID: <20190729123557.GA9131@dell5510> (raw)
In-Reply-To: <20190729121719.GA25075@rei.lan>

Hi Cyril,

> Hi!
> > NOTE: test is still a mess, even after porting it.
> > Cleaning it up would probably be its own patch as the best
> > solution would be to rewrite it from scratch.

> The patch looks good, acked.

> There are couple of things that could be done to make the code cleaner.
> For instance we should make use of the .restore_wallclock flag in the
> test structure. But let's do that in a subsequent patches.
+1

> Also I'm not 100% sure that this test belongs under the clock_gettime/
> directory, we do call clock_gettime() in the main test function but the
> whole test is about inserting leap second. Maybe we should keep the test
> under the clock_gettime directory and rename it to leapsec01.c or
> something like this, but I'm not 100% sure about this.
+1 Before 0051eab23 it was called leapsec_timer.c. I also consider leapsec01.c
as more descriptive. Anyone else against renaming it?

Kind regards,
Petr

  reply	other threads:[~2019-07-29 12:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 12:02 [LTP] [PATCH v2] syscalls/clock_gettime: Ported clock_gettime03.c to new API Petr Vorel
2019-07-29 12:17 ` Cyril Hrubis
2019-07-29 12:35   ` Petr Vorel [this message]
2019-07-31 12:54     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729123557.GA9131@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox