public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs
Date: Mon, 29 Jul 2019 16:19:21 +0200	[thread overview]
Message-ID: <20190729141920.GA4040@dell5510> (raw)
In-Reply-To: <20190703154709.20863-1-pvorel@suse.cz>

Hi Amir,

> Test requires btrfs otherwise it fails:
> WARNING: failed to open /dev/btrfs-control, skipping device
> registration: No such file or directory
> safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point,
> btrfs, 0, (nil)) failed: ENODEV
could you please test it?

Kind regards,
Petr
https://patchwork.ozlabs.org/patch/1126923/

> Cc: Christian Amann <camann@suse.com>
> Reported-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Amir,

> thanks a lot for a report and sorry for longer time to reply (vacation).
> Could you please test it? (I don't have any VM with kernel >= 4.5 && !btrfs).

> Kind regards,
> Petr

>  testcases/kernel/syscalls/ioctl/ioctl08.c | 6 ++++++
>  1 file changed, 6 insertions(+)

> diff --git a/testcases/kernel/syscalls/ioctl/ioctl08.c b/testcases/kernel/syscalls/ioctl/ioctl08.c
> index 8de80048c..dca898a65 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl08.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl08.c
> @@ -112,6 +112,11 @@ static void setup(void)
>  			sizeof(struct file_dedupe_range_info));
>  }

> +static const char *const needed_drivers[] = {
> +	"btrfs",
> +	NULL,
> +};
> +
>  static struct tst_test test = {
>  	.test = verify_ioctl,
>  	.tcnt = ARRAY_SIZE(tcases),
> @@ -122,6 +127,7 @@ static struct tst_test test = {
>  	.mount_device = 1,
>  	.mntpoint = MNTPOINT,
>  	.dev_fs_type = "btrfs",
> +	.needs_drivers = needed_drivers,
>  };
>  #else
>  	TST_TEST_TCONF(

  parent reply	other threads:[~2019-07-29 14:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03 15:47 [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs Petr Vorel
2019-07-09 10:24 ` Cyril Hrubis
2019-07-29 14:19 ` Petr Vorel [this message]
2019-07-31 20:51   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729141920.GA4040@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox