From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] m4: remove some useless m4
Date: Mon, 29 Jul 2019 16:42:46 +0200 [thread overview]
Message-ID: <20190729144227.GA8824@dell5510> (raw)
In-Reply-To: <20190729131619.GB27006@rei.lan>
Hi,
> > > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> > Acked-by: Petr Vorel <pvorel@suse.cz>
> > Although I wonder whether mixing 4 changes (even related to autoconf)
> > in single commit is a good idea (makes it a bit hard to review).
> Yes please, at least the SPDX conversion has to be in a separate patch.
+1
BTW m4/ltp-signalfd.m4 would require cleanup as well.
Kind regards,
Petr
next prev parent reply other threads:[~2019-07-29 14:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 10:48 [LTP] [PATCH] m4: remove useless ltp-securebits.m4 Yang Xu
2019-07-19 10:59 ` Xiao Yang
2019-07-22 9:52 ` [LTP] [PATCH v2 1/2] m4: remove some useless m4 Yang Xu
2019-07-22 9:52 ` [LTP] [PATCH v2 2/2] ltp-cap.m4: uncouple licap and cap_compare Yang Xu
2019-07-29 12:26 ` [LTP] [PATCH v2 1/2] m4: remove some useless m4 Petr Vorel
2019-07-29 13:16 ` Cyril Hrubis
2019-07-29 14:42 ` Petr Vorel [this message]
2019-07-30 5:18 ` Yang Xu
2019-07-30 5:45 ` [LTP] [PATCH v3 1/5] m4: remove useless ltp-securebits.m4 Yang Xu
2019-07-30 5:45 ` [LTP] [PATCH v3 2/5] m4: remove useless ltp-time.m4 Yang Xu
2019-07-30 5:45 ` [LTP] [PATCH v3 3/5] m4:remove useless ltp-fs_ioc_flags.m4 Yang Xu
2019-07-30 5:45 ` [LTP] [PATCH v3 4/5] m4: remove useless ltp-cgroupstats.m4 Yang Xu
2019-07-30 5:45 ` [LTP] [PATCH v3 5/5] m4: clean up ltp-signalfd.m4 Yang Xu
2019-08-02 8:57 ` [LTP] [PATCH v3 1/5] m4: remove useless ltp-securebits.m4 Petr Vorel
2019-07-22 9:59 ` [LTP] [PATCH] " Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729144227.GA8824@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox