[LTP] [PATCH v6 2/3] syscalls/copy_file_range01: add cross-device test

Petr Vorel
2019-07-29T14:10:11Z

Hi,

> > Amir has relaxed cross-device constraint since commit[1], I think we can test it in
> > copy_file_range01.

> > [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5dae222a5

> > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> > Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> Now sent to the correct patchset version:

> Whole patchset LGTM, but here we got quite a lot of failures after increasing
> test coverage with .all_filesystems = 1 (which use should be noted in commit
> message):

> copy_file_range02.c:120: FAIL: copy_file_range failed unexpectedly; expected EOVERFLOW, but got: EINVAL
> copy_file_range02.c:126: FAIL: copy_file_range returned wrong value: 16
> ...
> copy_file_range02.c:126: FAIL: copy_file_range returned wrong value: 16

Also .mount_device = 1 and .all_filesystems = 1 require
.needs_root = 1 definition or you get

tst_device.c:97: INFO: Not allowed to open /dev/loop-control. Are you root?: EACCES
tst_device.c:132: INFO: No free devices found
tst_device.c:308: BROK: Failed to acquire device

BTW I wonder whether these could be detected automatically.

Kind regards,
Petr