From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Hrubis <chrubis@suse.cz>
Date: Wed, 31 Jul 2019 14:28:54 +0200
Subject: [LTP] [PATCH v7 1/3] lib: alter find_free_loopdev()
In-Reply-To: <20190731120503.GC22537@dell5510>
References: <20190730110555.GB7528@rei.lan>
 <1564569629-2358-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
 <20190731120503.GC22537@dell5510>
Message-ID: <20190731122853.GA30487@rei.lan>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi!
> ...
> > +++ b/lib/tst_device.c
> ...
> > -			return 0;
> > +			if (path != NULL)
> > +				strncpy(path, buf, path_len);
> Is it safe to assume that path_len is *always* < 1024 (size of buf)?

strncpy() is tricky that it may not null-terminate the string if the
source is too long, I would have just added path[path_len-1] = 0 after
the strncpy() here.

> > +			return i;
> ...
> 
> 
> Kind regards,
> Petr

-- 
Cyril Hrubis
chrubis@suse.cz