From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test
Date: Fri, 2 Aug 2019 13:50:46 +0200 [thread overview]
Message-ID: <20190802115046.GB27727@rei> (raw)
In-Reply-To: <1564742081-2234-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
Hi!
> + /* Mask to show which attributes are supported on filesystem. */
> + if ((buf.stx_attributes_mask & FS_COMPR_FL) == 0)
> + tst_brk(TCONF, "filesystem doesn't support FS_COMPR_FL");
> + if ((buf.stx_attributes_mask & FS_APPEND_FL) == 0)
> + tst_brk(TCONF, "filesystem doesn't support FS_APPEND_FL");
> + if ((buf.stx_attributes_mask & FS_IMMUTABLE_FL) == 0)
> + tst_brk(TCONF, "filesystem doesn't support FS_IMMUTABLE_FL");
> + if ((buf.stx_attributes_mask & FS_NODUMP_FL) == 0)
> + tst_brk(TCONF, "filesystem doesn't support FS_NODUMP_FL");
I doubt that all these flags are either set or unset for a given
fileystem, can we rather than this set flags such as supp_compr etc and
disable only tests for a subset of unsupported flags rather than the
whole test?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-08-02 11:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 10:34 [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test Yang Xu
2019-08-02 11:50 ` Cyril Hrubis [this message]
2019-08-20 6:33 ` [LTP] [PATCH v2] " Yang Xu
2019-08-27 9:25 ` Petr Vorel
2019-08-27 9:58 ` Petr Vorel
2019-08-27 10:16 ` Cyril Hrubis
2019-09-11 10:22 ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-09-11 12:47 ` Cyril Hrubis
2019-09-12 3:28 ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-10-25 3:53 ` [LTP] [PATCH] " Yang Xu
2019-10-31 10:03 ` Yang Xu
2021-05-25 13:18 ` Li Wang
2021-05-25 14:16 ` Cyril Hrubis
2021-05-26 4:00 ` xuyang2018.jy
2021-05-26 8:31 ` Li Wang
2021-05-26 10:02 ` xuyang2018.jy
2021-11-10 13:28 ` Richard Palethorpe
2021-11-11 3:25 ` xuyang2018.jy
2019-08-28 3:56 ` [LTP] [PATCH v2] " Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802115046.GB27727@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox