From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 3/3] make: Add -Werror-implicit-function-declaration for all targets
Date: Fri, 2 Aug 2019 15:27:48 +0200 [thread overview]
Message-ID: <20190802132748.GA4749@dell5510> (raw)
In-Reply-To: <20190802130301.GC27727@rei>
Hi Cyril,
> Hi!
> > > diff --git a/include/mk/env_post.mk b/include/mk/env_post.mk
> > > index 913bdf5d1..3ffdd0b7f 100644
> > > --- a/include/mk/env_post.mk
> > > +++ b/include/mk/env_post.mk
> > > @@ -41,11 +41,9 @@ ifeq ($(UCLINUX),1)
> > > CPPFLAGS += -D__UCLIBC__ -DUCLINUX
> > > endif
> > > -ifeq ($(ANDROID),1)
> > > -# There are many undeclared functions, it's best not to accidentally overlook
> > > -# them.
> > > CFLAGS += -Werror-implicit-function-declaration
> > > +ifeq ($(ANDROID),1)
> > > LDFLAGS += -L$(top_builddir)/lib/android_libpthread
> > > LDFLAGS += -L$(top_builddir)/lib/android_librt
> > > endif
> > Ping, please. Drop it or merge?
> My opinion on Werror flags is that they should be on for development but
> disabled for releases and production. The question is how to implement
> something like this.
> On the other hand we do have a CI so most problems would be caught
> there...
Good point. I'll post a new patch remove it here and add it for travis.
It will be therefore disabled for Android, hope it's ok.
Kind regards,
Petr
prev parent reply other threads:[~2019-08-02 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 23:31 [LTP] [PATCH 0/3][RFC] Android fixes and -Werror-implicit-function-declaration as default Petr Vorel
2019-04-11 23:31 ` [LTP] [RFC PATCH 1/3] cve/cve-2014-0196: Don't use libutil for Android Petr Vorel
2019-04-12 19:39 ` Sandeep Patil
2019-04-14 9:59 ` Petr Vorel
2019-04-11 23:31 ` [LTP] [RFC PATCH 2/3] Add more missing <string.h> and <strings.h> includes Petr Vorel
2019-04-12 2:12 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-12 8:49 ` Cyril Hrubis
2019-04-12 8:48 ` Petr Vorel
2019-04-12 9:05 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-12 9:45 ` Cyril Hrubis
2019-04-12 9:46 ` Petr Vorel
2019-04-12 16:48 ` Enji Cooper
2019-04-11 23:31 ` [LTP] [RFC PATCH 3/3] make: Add -Werror-implicit-function-declaration for all targets Petr Vorel
2019-07-12 13:48 ` Petr Vorel
2019-08-02 13:03 ` Cyril Hrubis
2019-08-02 13:27 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802132748.GA4749@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox