public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 4/4] build: Move -Werror-implicit-function-declaration from make to build.sh
Date: Fri, 9 Aug 2019 12:07:01 +0200	[thread overview]
Message-ID: <20190809100701.GB27030@dell5510> (raw)
In-Reply-To: <20190809093354.GA13178@rei.lan>

Hi Cyril,

> > +CFLAGS="${CFLAGS:--Werror-implicit-function-declaration}"

> Shouldn't this be -Werror=implicit-function-declaration ?
Yes, it is. '${CFLAGS:-' part is POSIX shell substitute (${parameter:-[word]}
from [1]), the result is '-Werror=implicit-function-declaration' when CFLAGS is
empty or not set.
I might change it as

I might change it to more readable form:
DEFAULT_CFLAGS="-Werror-implicit-function-declaration"
CFLAGS="${CFLAGS:-$DEFAULT_CFLAGS}"

> Hmm, looks like both variants actually work, but the gcc manual speaks
> only about -Werror= one.


> Otherwise it looks good, acked.
Thx! Although I plan to send some RFC for moving ffsb as a subproject, it has a
low priority. So I'll merge this with your ack.

Kind regards,
Petr

[1] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02

  reply	other threads:[~2019-08-09 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 16:45 [LTP] [PATCH v3 4/4] build: Move -Werror-implicit-function-declaration from make to build.sh Petr Vorel
2019-08-09  9:33 ` Cyril Hrubis
2019-08-09 10:07   ` Petr Vorel [this message]
2019-08-09 10:35     ` Cyril Hrubis
2019-08-09 13:57       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190809100701.GB27030@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox