From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH ltp 2/5] runtest: rename gf*** and rwtest{1..5} in lvm.part{1, 2} and scsi_debug.part1
Date: Fri, 9 Aug 2019 16:13:54 +0200 [thread overview]
Message-ID: <20190809141354.GF32115@rei.lan> (raw)
In-Reply-To: <20190809062000.8671-2-yixin.zhang@intel.com>
Hi!
> There are lots tests with duplicated name gf*** and rwtest0{1..5} in the
> 3 runtest file but they are testing different fs. Rename them to
> distingulish.
>
> 1. Change gf*** to gf***_lvm/gf***_scsi
> 2. Chagne rwtest** to rwtest{1..8}**_lvm/rwtest{1..8}**_scsi, which the
> code 1..8 is the code for the target filesystem
I'm undecided on this one. On one hand I do not think that maintaining
unique names across different runtest files is feasible. On the other
hand this case is probably fine since it's unlikely that we will change
these files frequently.
Does anybody have strong opinion on this?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-08-09 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 6:19 [LTP] [PATCH ltp 1/5] runtest/scsi_debug.part1: remove duplicated test for reiserfs filesystem Yixin Zhang
2019-08-09 6:19 ` [LTP] [PATCH ltp 2/5] runtest: rename gf*** and rwtest{1..5} in lvm.part{1, 2} and scsi_debug.part1 Yixin Zhang
2019-08-09 14:13 ` Cyril Hrubis [this message]
2019-09-02 9:00 ` Petr Vorel
2019-08-09 6:19 ` [LTP] [PATCH ltp 3/5] runtest/ltp-aiodio.part4: rename aiodio_append tests to avoid duplication Yixin Zhang
2019-09-02 9:16 ` Petr Vorel
2019-08-09 6:19 ` [LTP] [PATCH ltp 4/5] runtest/crashme: rename mem01 " Yixin Zhang
2019-08-30 13:14 ` Petr Vorel
2019-09-02 1:39 ` Zhang, Yixin
2019-08-09 6:20 ` [LTP] [PATCH ltp 5/5] runtest/numa: rename duplicated test cases Yixin Zhang
2019-08-09 13:43 ` Cyril Hrubis
2019-08-09 13:58 ` [LTP] [PATCH ltp 1/5] runtest/scsi_debug.part1: remove duplicated test for reiserfs filesystem Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809141354.GF32115@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox