public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/statx04: use stx_attributes_mask before test
Date: Tue, 27 Aug 2019 12:16:44 +0200	[thread overview]
Message-ID: <20190827101644.GA30582@rei> (raw)
In-Reply-To: <20190827095858.GB28859@dell5510>

Hi!
> also Cyril noted on Github issue #557 [1]:
> "However I'm not sure that we should do this since kernel devs declared this to be bug after all."
> 
> So maybe we should wait before applying it.
> 
> @Cyril: can you please post link to discussion in LKML?

I've talked to Jan Kara in person while developing these tests, so there
is no track of this discussion.

I guess that the best we can do here is to:

* Apply this patch, since the test should generally check only for flags
  that are supported in the bitflag returned by the syscall

* Add another test that checks that these bitflags are enabled for new
  enough kernels for certain set of filesystems

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2019-08-27 10:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 10:34 [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test Yang Xu
2019-08-02 11:50 ` Cyril Hrubis
2019-08-20  6:33   ` [LTP] [PATCH v2] " Yang Xu
2019-08-27  9:25     ` Petr Vorel
2019-08-27  9:58       ` Petr Vorel
2019-08-27 10:16         ` Cyril Hrubis [this message]
2019-09-11 10:22           ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-09-11 12:47             ` Cyril Hrubis
2019-09-12  3:28               ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-10-25  3:53               ` [LTP] [PATCH] " Yang Xu
2019-10-31 10:03                 ` Yang Xu
2021-05-25 13:18                 ` Li Wang
2021-05-25 14:16                   ` Cyril Hrubis
2021-05-26  4:00                     ` xuyang2018.jy
2021-05-26  8:31                       ` Li Wang
2021-05-26 10:02                         ` xuyang2018.jy
2021-11-10 13:28                 ` Richard Palethorpe
2021-11-11  3:25                   ` xuyang2018.jy
2019-08-28  3:56       ` [LTP] [PATCH v2] " Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827101644.GA30582@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox