From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_net.sh: Fix root detection on netns on new shell API
Date: Thu, 29 Aug 2019 21:21:22 +0200 [thread overview]
Message-ID: <20190829192120.GA14614@dell5510> (raw)
In-Reply-To: <888e8f74-278c-ae3f-c8c5-3b8790f634d3@oracle.com>
Hi Alexey,
> > init_ltp_netspace()
> > {
> > tst_test_cmds ip
> > - tst_require_root_
> > + [ -z "$TST_USE_LEGACY_API" ] && _tst_require_root || tst_require_root
> Can we fix tst_require_root_() instead?
I'll do.
I wanted to use API variable than call internal function. It's not a big issue
and this function is called in _tst_require_root anyway.
NOTE: I've posted a patch which move variable and link setup to separate
function, but I'm going to reject it myself. It's not an improvement and does
not solve this solution. Sorry for the noise.
Kind regards,
Petr
next prev parent reply other threads:[~2019-08-29 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 14:11 [LTP] [PATCH] tst_net.sh: Fix root detection on netns on new shell API Petr Vorel
2019-08-27 12:22 ` Alexey Kodanev
2019-08-29 19:21 ` Petr Vorel [this message]
2019-08-29 19:35 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829192120.GA14614@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox