public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] tst_net.sh: Move variable and link setup to separate function
Date: Thu, 29 Aug 2019 21:25:18 +0200	[thread overview]
Message-ID: <20190829192518.GA1197@dell5510> (raw)
In-Reply-To: <20190829190709.30834-1-pvorel@suse.cz>

Hi,

> When using LTP with netns ("Single Host Configuration"),
> init_ltp_netspace before running test which performs checking for
> TST_NEEDS_ROOT=1, therefore adding it is not enough.
> It fails on adding netns:

> RTNETLINK answers: Operation not permitted
> sctp01 1 TBROK: ip li add name ltp_ns_veth1 type veth peer name ltp_ns_veth2 failed

> NOTE: tst_restore_ipaddr is called before running tests only on netns,
> in init_ltp_netspace, therefore tst_require_root_ as a check is enough.

> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Rejecting it myself, as it's not an improvement.

Kind regards,
Petr

      parent reply	other threads:[~2019-08-29 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 19:07 [LTP] [PATCH 1/2] tst_net.sh: Move variable and link setup to separate function Petr Vorel
2019-08-29 19:07 ` [LTP] [PATCH 2/2] tst_net.sh: Rename variables to comply name policy Petr Vorel
2019-08-29 19:25   ` Petr Vorel
2019-08-29 19:25 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829192518.GA1197@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox