public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Zhang, Yixin <yixin.zhang@intel.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH ltp 4/5] runtest/crashme: rename mem01 to avoid duplication
Date: Mon, 2 Sep 2019 09:39:47 +0800	[thread overview]
Message-ID: <20190902013947.GA19200@yixin-dev.sh.intel.com> (raw)
In-Reply-To: <20190830131359.GA28103@dell5510>

Hi Petr,

Understood and thanks.
Could you aslo have a look at "[PATCH ltp 3/5] runtest/ltp-aiodio.part4:
rename aiodio_append tests to avoid duplication"? That case is different
than this one. In that case cases with differnt commands share the same
name.

Br.
Yixin

On 2019-08-30 at 15:14:00 +0200, Petr Vorel wrote:
> Hi Yixin,
> 
> > mem01 is already in runtest file mm. Rename the test to mem01_crashme
> > here.
> 
> ...
> > -mem01 mem01 -r
> > +mem01_crashme mem01 -r
> >  # Memory eater. Loves to be run in parallel with other programs.
> >  # May panic on buggy systems if the OOM killer was not fast enough :-)
> >  fork12 fork12
> 
> Refused this one, as it's the same case as [5/5]. Quote Cyril:
> https://patchwork.ozlabs.org/comment/2234376/
> The test names in runtest files were never promised to be unique, if the
> command line is the same the test id should probably stay the same.
> 
> 
> Kind regards,
> Petr

  reply	other threads:[~2019-09-02  1:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  6:19 [LTP] [PATCH ltp 1/5] runtest/scsi_debug.part1: remove duplicated test for reiserfs filesystem Yixin Zhang
2019-08-09  6:19 ` [LTP] [PATCH ltp 2/5] runtest: rename gf*** and rwtest{1..5} in lvm.part{1, 2} and scsi_debug.part1 Yixin Zhang
2019-08-09 14:13   ` Cyril Hrubis
2019-09-02  9:00     ` Petr Vorel
2019-08-09  6:19 ` [LTP] [PATCH ltp 3/5] runtest/ltp-aiodio.part4: rename aiodio_append tests to avoid duplication Yixin Zhang
2019-09-02  9:16   ` Petr Vorel
2019-08-09  6:19 ` [LTP] [PATCH ltp 4/5] runtest/crashme: rename mem01 " Yixin Zhang
2019-08-30 13:14   ` Petr Vorel
2019-09-02  1:39     ` Zhang, Yixin [this message]
2019-08-09  6:20 ` [LTP] [PATCH ltp 5/5] runtest/numa: rename duplicated test cases Yixin Zhang
2019-08-09 13:43   ` Cyril Hrubis
2019-08-09 13:58 ` [LTP] [PATCH ltp 1/5] runtest/scsi_debug.part1: remove duplicated test for reiserfs filesystem Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902013947.GA19200@yixin-dev.sh.intel.com \
    --to=yixin.zhang@intel.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox