From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 2/4] BPF: Sanity check creating and updating maps
Date: Mon, 2 Sep 2019 16:05:32 +0200 [thread overview]
Message-ID: <20190902140531.GA10860@rei.lan> (raw)
In-Reply-To: <456316863.8154593.1566823938723.JavaMail.zimbra@redhat.com>
Hi!
> Small nit (maybe personal preference), I'd rather make this check for
> map_types.attr, as opposed to test number / some position in array.
Sounds good.
> > + case 0:
> > + if (TST_RET != -1 || TST_ERR != ENOENT) {
> > + tst_res(TFAIL | TTERRNO,
> > + "Empty hash map lookup should fail with ENOENT");
> > + } else {
> > + tst_res(TPASS | TTERRNO, "Empty hash map lookup");
> > + }
> > + break;
> > + case 1:
> > + if (TST_RET != -1) {
> > + for (i = 0;;) {
> > + if (val_get[i] != 0) {
> > + tst_res(TFAIL,
> > + "Preallocated array map val not zero");
>
> If we hit this TFAIL, will the loop terminate?
My bad, I will change this to use proper for() loop.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-09-02 14:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 11:10 [LTP] [PATCH v4 0/4] Basic eBPF tests Cyril Hrubis
2019-08-26 11:10 ` [LTP] [PATCH v4 1/4] BPF: Essential headers for map creation Cyril Hrubis
2019-08-26 11:10 ` [LTP] [PATCH v4 2/4] BPF: Sanity check creating and updating maps Cyril Hrubis
2019-08-26 12:52 ` Jan Stancek
2019-09-02 14:05 ` Cyril Hrubis [this message]
2019-08-26 11:10 ` [LTP] [PATCH v4 3/4] BPF: Essential headers for a basic program Cyril Hrubis
2019-08-26 11:10 ` [LTP] [PATCH v4 4/4] BPF: Sanity check creating a program Cyril Hrubis
2019-08-26 16:05 ` Jan Stancek
2019-08-28 7:41 ` Clemens Famulla-Conrad
2019-08-26 14:29 ` [LTP] [PATCH v4 0/4] Basic eBPF tests Jan Stancek
2019-08-28 7:26 ` Clemens Famulla-Conrad
2019-08-28 7:46 ` Jan Stancek
2019-08-28 10:15 ` Clemens Famulla-Conrad
2019-09-02 14:55 ` Cyril Hrubis
2019-09-03 5:50 ` Jan Stancek
2019-09-03 8:58 ` Cyril Hrubis
2019-09-03 9:51 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902140531.GA10860@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox