From: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] madvise09:Change PAGES size to the value more than 32
Date: Wed, 4 Sep 2019 11:32:25 -0300 [thread overview]
Message-ID: <20190904143224.GH4101@calabresa> (raw)
In-Reply-To: <1567576823-10080-1-git-send-email-shuang.qiu@oracle.com>
On Wed, Sep 04, 2019 at 02:00:23PM +0800, shuang.qiu@oracle.com wrote:
> From: Shuang Qiu <shuang.qiu@oracle.com>
>
> In upstream patch 1a61ab (mm: memcontrol: replace zone summing with lruvec_page_state()),
> it modify the lruvec state in batch,equal and less than 32 MADV_FREE pages will not trigger
> the account of lruvec_stat,and will not be free in memory pressure either.
> So the testcase may fail with:
> ...
> madvise09.c:219: INFO: Memory hungry child 6178 started, try 10
> madvise09.c:254: INFO: Memory map: pppppppppppppppppppppppppppppppp
> madvise09.c:259: FAIL: No MADV_FREE page was freed on low memory
> ...
> Change the PAGES to the value more than 32 can fix such issue.
>
> Signed-off-by: Shuang Qiu <shuang.qiu@oracle.com>
On ppc64le, I was getting retries, as OOM was getting hit. The test would
ultimately time out. This fixes it for me.
Thanks.
Cascardo.
Tested-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
> testcases/kernel/syscalls/madvise/madvise09.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/madvise/madvise09.c b/testcases/kernel/syscalls/madvise/madvise09.c
> index 01075f6..3759053 100644
> --- a/testcases/kernel/syscalls/madvise/madvise09.c
> +++ b/testcases/kernel/syscalls/madvise/madvise09.c
> @@ -57,7 +57,7 @@ static int sleep_between_faults;
>
> static int swap_accounting_enabled;
>
> -#define PAGES 32
> +#define PAGES 64
> #define TOUCHED_PAGE1 0
> #define TOUCHED_PAGE2 10
>
> --
> 1.9.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2019-09-04 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 6:00 [LTP] [PATCH] madvise09:Change PAGES size to the value more than 32 shuang.qiu
2019-09-04 14:32 ` Thadeu Lima de Souza Cascardo [this message]
2019-09-05 8:29 ` Li Wang
2019-09-05 10:01 ` Shuang Qiu
2019-09-05 10:29 ` Li Wang
2019-09-11 11:19 ` Cyril Hrubis
2019-09-12 2:51 ` Li Wang
2019-09-12 3:35 ` Shuang Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904143224.GH4101@calabresa \
--to=cascardo@canonical.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox