From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/acct02: Improve logging
Date: Tue, 17 Sep 2019 16:01:19 +0200 [thread overview]
Message-ID: <20190917140119.GA20524@x230> (raw)
In-Reply-To: <20190917112230.GA28255@rei>
Hi,
> > Problem with s390 is caused by big endianess:
> > ac_version != 3 (131)
> Hmm, 131 == 83 hex, so there is one more bit turned on.
> > I suspect a bug in UNPACK(), but don't know how to fix it.
> Isn't UNPACK() used only for the timestamps?
Yep, you're right.
> The ac_version is a char, so this really looks like some strange kernel
> bug.
> > Failures on x86_64:
> > * various recent kernels 5.2.9 / 5.3, 4.20 on Debian, using v3:
> > acct02.c:222: INFO: Verifying using 'struct acct_v3'
> > acct02.c:174: INFO: == loop 1 ==
> > acct02.c:81: INFO: ac_comm != 'acct02_helper' ('acct02')
> > acct02.c:174: INFO: == loop 2 ==
> > acct02.c:81: INFO: ac_comm != 'acct02_helper' ('acct02')
> > acct02.c:132: INFO: ac_exitcode != 65280 (0)
> > acct02.c:140: INFO: ac_ppid != 18029 (18028)
> > acct02.c:174: INFO: == loop 3 ==
> > acct02.c:81: INFO: ac_comm != 'acct02_helper' ('acct02')
> > acct02.c:132: INFO: ac_exitcode != 65280 (0)
> > acct02.c:140: INFO: ac_ppid != 18029 (18028)
> > acct02.c:187: INFO: Number of accounting file entries tested: 2
> > acct02.c:191: FAIL: acct() wrote incorrect file contents!
> > * 3.10 on CentOS using v3:
> > acct02.c:82: INFO: ac_comm != 'acct02_helper' ('')
> > acct02.c:88: INFO: ac_btime < 1568406976 (0)
> > acct02.c:133: INFO: ac_exitcode != 32768 (0)
> > acct02.c:141: INFO: ac_ppid != 19863 (0)
> > acct02.c:147: INFO: ac_version != 3 (0)
> > acct02.c:152: INFO: ac_pid < 1 (0)
> > acct02.c:188: INFO: Number of accounting file entries tested: 0
> > => this looks to be completely wrong.
> > Other distros using various kernels (both old and recent) using struct
> > acct_v3 works well, so the bug might be some specific kernel
> > configuration.
> That does look like the structure has been filled in by a kernel
> incorrectly.
...
> > @@ -123,26 +170,27 @@ static void run(void)
> > run_command();
> > acct(NULL);
> > - entry_count = 0;
> > do {
> > + tst_res(TINFO, "== loop %d ==", ++i);
> > +
> Maybe I would call this "== entry %d ==" or something like that.
Sure, that's better, I'll change it.
...
> Otherwise the patch looks good, at least we can see now which checks
> have failed.
If nobody objects, I'll merge it with previous change.
Kind regards,
Petr
next prev parent reply other threads:[~2019-09-17 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 20:53 [LTP] [PATCH] syscalls/acct02: Improve logging Petr Vorel
2019-09-17 11:22 ` Cyril Hrubis
2019-09-17 14:01 ` Petr Vorel [this message]
2019-09-17 16:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917140119.GA20524@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox