* [LTP] [PATCH] cgroup_regression_test.sh: Remove obselte test_5
@ 2019-09-19 9:10 Yang Xu
2019-09-19 9:45 ` Cyril Hrubis
0 siblings, 1 reply; 7+ messages in thread
From: Yang Xu @ 2019-09-19 9:10 UTC (permalink / raw)
To: ltp
test_5 is a very old regresstion test and kernel code has been
rewritten completely since 2.6. No user will use such old kernel
code to test. So I think we can remove it.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
.../cgroup/cgroup_regression_test.sh | 75 -------------------
1 file changed, 75 deletions(-)
-------------------------
a discussion about it:
https://patchwork.ozlabs.org/patch/1113680/
-------------------------
diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
index e197f5d3f..a32ed172c 100755
--- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
+++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
@@ -232,81 +232,6 @@ test4()
tst_res TPASS "no lockdep BUG was found"
}
-#---------------------------------------------------------------------------
-# Bug: When mount cgroup fs and the fs was busy, root_count should not be
-# decremented in cgroup_kill_sb()
-# Kernel: 2.6.29-rcX
-# Links: https://openvz.org/pipermail/devel/2009-January/016345.html
-# http://lkml.org/lkml/2009/1/28/190
-# Fix: commit 839ec5452ebfd5905b9c69b20ceb640903a8ea1a
-#---------------------------------------------------------------------------
-test5()
-{
- local mounted
- local failing
- local mntpoint
-
- local lines=`cat /proc/cgroups | wc -l`
- if [ $lines -le 2 ]; then
- tst_res TCONF "require at least 2 cgroup subsystems"
- return
- fi
-
- local subsys1=`tail -n 1 /proc/cgroups | awk '{ print $1 }'`
- local subsys2=`tail -n 2 /proc/cgroups | head -1 | awk '{ print $1 }'`
-
- # Accounting here for the fact that the chosen subsystems could
- # have been already previously mounted at boot time: in such a
- # case we must skip the initial co-mount step (which would
- # fail anyway) and properly re-organize the $mntpoint and
- # $failing params to be used in the following expected-to-fail
- # mount action. Note that the subsysN name itself will be listed
- # amongst mounts options.
- get_cgroup_mountpoint $subsys1 >/dev/null && mounted=$subsys1
- [ -z "$mounted" ] && get_cgroup_mountpoint $subsys2 >/dev/null && mounted=$subsys2
- if [ -z "$mounted" ]; then
- mntpoint=cgroup
- failing=$subsys1
- mount -t cgroup -o $subsys1,$subsys2 xxx $mntpoint/
- if [ $? -ne 0 ]; then
- tst_res TFAIL "mount $subsys1 and $subsys2 failed"
- return
- fi
- else
- # Use the pre-esistent mountpoint as $mntpoint and use a
- # co-mount with $failing: this way the 2nd mount will
- # also fail (as expected) in this 'mirrored' configuration.
- mntpoint=$(get_cgroup_mountpoint $mounted)
- failing=$subsys1,$subsys2
- fi
-
- # This 2nd mount has been properly configured to fail
- mount -t cgroup -o $failing xxx $mntpoint/ 2> /dev/null
- if [ $? -eq 0 ]; then
- tst_res TFAIL "mount $failing should fail"
- # Do NOT unmount pre-existent mountpoints...
- [ -z "$mounted" ] && umount $mntpoint/
- return
- fi
-
- mkdir $mntpoint/0
- # Otherwise we can't attach task
- if [ "$subsys1" = cpuset -o "$subsys2" = cpuset ]; then
- echo 0 > $mntpoint/0/cpuset.cpus 2> /dev/null
- echo 0 > $mntpoint/0/cpuset.mems 2> /dev/null
- fi
-
- sleep 100 &
- echo $! > $mntpoint/0/tasks
-
- kill -TERM $! > /dev/null
- wait $! 2>/dev/null
- rmdir $mntpoint/0
- # Do NOT unmount pre-existent mountpoints...
- [ -z "$mounted" ] && umount $mntpoint/
- check_kernel_bug
-}
-
#---------------------------------------------------------------------------
# Bug: There was a race between cgroup_clone and umount
# Kernel: 2.6.24 - 2.6.28, 2.6.29-rcX
--
2.18.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [LTP] [PATCH] cgroup_regression_test.sh: Remove obselte test_5
2019-09-19 9:10 [LTP] [PATCH] cgroup_regression_test.sh: Remove obselte test_5 Yang Xu
@ 2019-09-19 9:45 ` Cyril Hrubis
2019-09-19 9:54 ` Yang Xu
2019-09-19 10:38 ` [LTP] [PATCH v2] " Yang Xu
0 siblings, 2 replies; 7+ messages in thread
From: Cyril Hrubis @ 2019-09-19 9:45 UTC (permalink / raw)
To: ltp
Hi!
> test_5 is a very old regresstion test and kernel code has been
> rewritten completely since 2.6. No user will use such old kernel
> code to test. So I think we can remove it.
Unfortunatelly we also have to renumber the tests and change TST_CNT
otherwise the test library will attempt to run a function that is not
present.
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
> .../cgroup/cgroup_regression_test.sh | 75 -------------------
> 1 file changed, 75 deletions(-)
>
> -------------------------
> a discussion about it:
> https://patchwork.ozlabs.org/patch/1113680/
> -------------------------
>
> diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> index e197f5d3f..a32ed172c 100755
> --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> @@ -232,81 +232,6 @@ test4()
> tst_res TPASS "no lockdep BUG was found"
> }
>
> -#---------------------------------------------------------------------------
> -# Bug: When mount cgroup fs and the fs was busy, root_count should not be
> -# decremented in cgroup_kill_sb()
> -# Kernel: 2.6.29-rcX
> -# Links: https://openvz.org/pipermail/devel/2009-January/016345.html
> -# http://lkml.org/lkml/2009/1/28/190
> -# Fix: commit 839ec5452ebfd5905b9c69b20ceb640903a8ea1a
> -#---------------------------------------------------------------------------
> -test5()
> -{
> - local mounted
> - local failing
> - local mntpoint
> -
> - local lines=`cat /proc/cgroups | wc -l`
> - if [ $lines -le 2 ]; then
> - tst_res TCONF "require at least 2 cgroup subsystems"
> - return
> - fi
> -
> - local subsys1=`tail -n 1 /proc/cgroups | awk '{ print $1 }'`
> - local subsys2=`tail -n 2 /proc/cgroups | head -1 | awk '{ print $1 }'`
> -
> - # Accounting here for the fact that the chosen subsystems could
> - # have been already previously mounted at boot time: in such a
> - # case we must skip the initial co-mount step (which would
> - # fail anyway) and properly re-organize the $mntpoint and
> - # $failing params to be used in the following expected-to-fail
> - # mount action. Note that the subsysN name itself will be listed
> - # amongst mounts options.
> - get_cgroup_mountpoint $subsys1 >/dev/null && mounted=$subsys1
> - [ -z "$mounted" ] && get_cgroup_mountpoint $subsys2 >/dev/null && mounted=$subsys2
> - if [ -z "$mounted" ]; then
> - mntpoint=cgroup
> - failing=$subsys1
> - mount -t cgroup -o $subsys1,$subsys2 xxx $mntpoint/
> - if [ $? -ne 0 ]; then
> - tst_res TFAIL "mount $subsys1 and $subsys2 failed"
> - return
> - fi
> - else
> - # Use the pre-esistent mountpoint as $mntpoint and use a
> - # co-mount with $failing: this way the 2nd mount will
> - # also fail (as expected) in this 'mirrored' configuration.
> - mntpoint=$(get_cgroup_mountpoint $mounted)
> - failing=$subsys1,$subsys2
> - fi
> -
> - # This 2nd mount has been properly configured to fail
> - mount -t cgroup -o $failing xxx $mntpoint/ 2> /dev/null
> - if [ $? -eq 0 ]; then
> - tst_res TFAIL "mount $failing should fail"
> - # Do NOT unmount pre-existent mountpoints...
> - [ -z "$mounted" ] && umount $mntpoint/
> - return
> - fi
> -
> - mkdir $mntpoint/0
> - # Otherwise we can't attach task
> - if [ "$subsys1" = cpuset -o "$subsys2" = cpuset ]; then
> - echo 0 > $mntpoint/0/cpuset.cpus 2> /dev/null
> - echo 0 > $mntpoint/0/cpuset.mems 2> /dev/null
> - fi
> -
> - sleep 100 &
> - echo $! > $mntpoint/0/tasks
> -
> - kill -TERM $! > /dev/null
> - wait $! 2>/dev/null
> - rmdir $mntpoint/0
> - # Do NOT unmount pre-existent mountpoints...
> - [ -z "$mounted" ] && umount $mntpoint/
> - check_kernel_bug
> -}
> -
> #---------------------------------------------------------------------------
> # Bug: There was a race between cgroup_clone and umount
> # Kernel: 2.6.24 - 2.6.28, 2.6.29-rcX
> --
> 2.18.1
>
>
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 7+ messages in thread* [LTP] [PATCH] cgroup_regression_test.sh: Remove obselte test_5
2019-09-19 9:45 ` Cyril Hrubis
@ 2019-09-19 9:54 ` Yang Xu
2019-09-19 10:38 ` [LTP] [PATCH v2] " Yang Xu
1 sibling, 0 replies; 7+ messages in thread
From: Yang Xu @ 2019-09-19 9:54 UTC (permalink / raw)
To: ltp
on 2019/09/19 17:45, Cyril Hrubis wrote:
> Hi!
>> test_5 is a very old regresstion test and kernel code has been
>> rewritten completely since 2.6. No user will use such old kernel
>> code to test. So I think we can remove it.
>
> Unfortunatelly we also have to renumber the tests and change TST_CNT
> otherwise the test library will attempt to run a function that is not
> present.
>
Oh, Sorry. I forgot it(I am not familiar with ltp shell test frame, I am
going to read doc/test-writing-guidelines.txt). Also, I will send a v2
patch.
>> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
>> ---
>> .../cgroup/cgroup_regression_test.sh | 75 -------------------
>> 1 file changed, 75 deletions(-)
>>
>> -------------------------
>> a discussion about it:
>> https://patchwork.ozlabs.org/patch/1113680/
>> -------------------------
>>
>> diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
>> index e197f5d3f..a32ed172c 100755
>> --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
>> +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
>> @@ -232,81 +232,6 @@ test4()
>> tst_res TPASS "no lockdep BUG was found"
>> }
>>
>> -#---------------------------------------------------------------------------
>> -# Bug: When mount cgroup fs and the fs was busy, root_count should not be
>> -# decremented in cgroup_kill_sb()
>> -# Kernel: 2.6.29-rcX
>> -# Links: https://openvz.org/pipermail/devel/2009-January/016345.html
>> -# http://lkml.org/lkml/2009/1/28/190
>> -# Fix: commit 839ec5452ebfd5905b9c69b20ceb640903a8ea1a
>> -#---------------------------------------------------------------------------
>> -test5()
>> -{
>> - local mounted
>> - local failing
>> - local mntpoint
>> -
>> - local lines=`cat /proc/cgroups | wc -l`
>> - if [ $lines -le 2 ]; then
>> - tst_res TCONF "require at least 2 cgroup subsystems"
>> - return
>> - fi
>> -
>> - local subsys1=`tail -n 1 /proc/cgroups | awk '{ print $1 }'`
>> - local subsys2=`tail -n 2 /proc/cgroups | head -1 | awk '{ print $1 }'`
>> -
>> - # Accounting here for the fact that the chosen subsystems could
>> - # have been already previously mounted at boot time: in such a
>> - # case we must skip the initial co-mount step (which would
>> - # fail anyway) and properly re-organize the $mntpoint and
>> - # $failing params to be used in the following expected-to-fail
>> - # mount action. Note that the subsysN name itself will be listed
>> - # amongst mounts options.
>> - get_cgroup_mountpoint $subsys1 >/dev/null && mounted=$subsys1
>> - [ -z "$mounted" ] && get_cgroup_mountpoint $subsys2 >/dev/null && mounted=$subsys2
>> - if [ -z "$mounted" ]; then
>> - mntpoint=cgroup
>> - failing=$subsys1
>> - mount -t cgroup -o $subsys1,$subsys2 xxx $mntpoint/
>> - if [ $? -ne 0 ]; then
>> - tst_res TFAIL "mount $subsys1 and $subsys2 failed"
>> - return
>> - fi
>> - else
>> - # Use the pre-esistent mountpoint as $mntpoint and use a
>> - # co-mount with $failing: this way the 2nd mount will
>> - # also fail (as expected) in this 'mirrored' configuration.
>> - mntpoint=$(get_cgroup_mountpoint $mounted)
>> - failing=$subsys1,$subsys2
>> - fi
>> -
>> - # This 2nd mount has been properly configured to fail
>> - mount -t cgroup -o $failing xxx $mntpoint/ 2> /dev/null
>> - if [ $? -eq 0 ]; then
>> - tst_res TFAIL "mount $failing should fail"
>> - # Do NOT unmount pre-existent mountpoints...
>> - [ -z "$mounted" ] && umount $mntpoint/
>> - return
>> - fi
>> -
>> - mkdir $mntpoint/0
>> - # Otherwise we can't attach task
>> - if [ "$subsys1" = cpuset -o "$subsys2" = cpuset ]; then
>> - echo 0 > $mntpoint/0/cpuset.cpus 2> /dev/null
>> - echo 0 > $mntpoint/0/cpuset.mems 2> /dev/null
>> - fi
>> -
>> - sleep 100 &
>> - echo $! > $mntpoint/0/tasks
>> -
>> - kill -TERM $! > /dev/null
>> - wait $! 2>/dev/null
>> - rmdir $mntpoint/0
>> - # Do NOT unmount pre-existent mountpoints...
>> - [ -z "$mounted" ] && umount $mntpoint/
>> - check_kernel_bug
>> -}
>> -
>> #---------------------------------------------------------------------------
>> # Bug: There was a race between cgroup_clone and umount
>> # Kernel: 2.6.24 - 2.6.28, 2.6.29-rcX
>> --
>> 2.18.1
>>
>>
>>
>>
>> --
>> Mailing list info: https://lists.linux.it/listinfo/ltp
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [LTP] [PATCH v2] cgroup_regression_test.sh: Remove obselte test_5
2019-09-19 9:45 ` Cyril Hrubis
2019-09-19 9:54 ` Yang Xu
@ 2019-09-19 10:38 ` Yang Xu
2019-09-19 14:09 ` Petr Vorel
1 sibling, 1 reply; 7+ messages in thread
From: Yang Xu @ 2019-09-19 10:38 UTC (permalink / raw)
To: ltp
test_5 is a very old regresstion test and kernel code has been
rewritten completely since 2.6. No user will use such old kernel
code to test. So I think we can remove it.
Also rename test10 as test5, modify TST_CNT.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
---
...ssion_10_1.sh => cgroup_regression_5_1.sh} | 0
...ssion_10_2.sh => cgroup_regression_5_2.sh} | 0
.../cgroup/cgroup_regression_test.sh | 111 +++---------------
3 files changed, 18 insertions(+), 93 deletions(-)
rename testcases/kernel/controllers/cgroup/{cgroup_regression_10_1.sh => cgroup_regression_5_1.sh} (100%)
rename testcases/kernel/controllers/cgroup/{cgroup_regression_10_2.sh => cgroup_regression_5_2.sh} (100%)
diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_10_1.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_5_1.sh
similarity index 100%
rename from testcases/kernel/controllers/cgroup/cgroup_regression_10_1.sh
rename to testcases/kernel/controllers/cgroup/cgroup_regression_5_1.sh
diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_10_2.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_5_2.sh
similarity index 100%
rename from testcases/kernel/controllers/cgroup/cgroup_regression_10_2.sh
rename to testcases/kernel/controllers/cgroup/cgroup_regression_5_2.sh
diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
index e197f5d3f..1f7f3820e 100755
--- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
+++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
@@ -7,7 +7,7 @@
TST_TESTFUNC=test
TST_SETUP=do_setup
TST_CLEANUP=do_cleanup
-TST_CNT=10
+TST_CNT=9
TST_NEEDS_ROOT=1
TST_NEEDS_TMPDIR=1
TST_NEEDS_CMDS="awk dmesg find mountpoint rmdir"
@@ -233,77 +233,28 @@ test4()
}
#---------------------------------------------------------------------------
-# Bug: When mount cgroup fs and the fs was busy, root_count should not be
-# decremented in cgroup_kill_sb()
-# Kernel: 2.6.29-rcX
-# Links: https://openvz.org/pipermail/devel/2009-January/016345.html
-# http://lkml.org/lkml/2009/1/28/190
-# Fix: commit 839ec5452ebfd5905b9c69b20ceb640903a8ea1a
+# Bug: When running 2 concurrent mount/umount threads, kernel WARNING
+# may be triggered, but it's VFS' issue but not cgroup.
+# Kernel: 2.6.24 - 2.6.29-rcX
+# Links: http://lkml.org/lkml/2009/1/4/354
+# Fix: commit 1a88b5364b535edaa321d70a566e358390ff0872
#---------------------------------------------------------------------------
test5()
{
- local mounted
- local failing
- local mntpoint
-
- local lines=`cat /proc/cgroups | wc -l`
- if [ $lines -le 2 ]; then
- tst_res TCONF "require at least 2 cgroup subsystems"
- return
- fi
-
- local subsys1=`tail -n 1 /proc/cgroups | awk '{ print $1 }'`
- local subsys2=`tail -n 2 /proc/cgroups | head -1 | awk '{ print $1 }'`
-
- # Accounting here for the fact that the chosen subsystems could
- # have been already previously mounted at boot time: in such a
- # case we must skip the initial co-mount step (which would
- # fail anyway) and properly re-organize the $mntpoint and
- # $failing params to be used in the following expected-to-fail
- # mount action. Note that the subsysN name itself will be listed
- # amongst mounts options.
- get_cgroup_mountpoint $subsys1 >/dev/null && mounted=$subsys1
- [ -z "$mounted" ] && get_cgroup_mountpoint $subsys2 >/dev/null && mounted=$subsys2
- if [ -z "$mounted" ]; then
- mntpoint=cgroup
- failing=$subsys1
- mount -t cgroup -o $subsys1,$subsys2 xxx $mntpoint/
- if [ $? -ne 0 ]; then
- tst_res TFAIL "mount $subsys1 and $subsys2 failed"
- return
- fi
- else
- # Use the pre-esistent mountpoint as $mntpoint and use a
- # co-mount with $failing: this way the 2nd mount will
- # also fail (as expected) in this 'mirrored' configuration.
- mntpoint=$(get_cgroup_mountpoint $mounted)
- failing=$subsys1,$subsys2
- fi
-
- # This 2nd mount has been properly configured to fail
- mount -t cgroup -o $failing xxx $mntpoint/ 2> /dev/null
- if [ $? -eq 0 ]; then
- tst_res TFAIL "mount $failing should fail"
- # Do NOT unmount pre-existent mountpoints...
- [ -z "$mounted" ] && umount $mntpoint/
- return
- fi
-
- mkdir $mntpoint/0
- # Otherwise we can't attach task
- if [ "$subsys1" = cpuset -o "$subsys2" = cpuset ]; then
- echo 0 > $mntpoint/0/cpuset.cpus 2> /dev/null
- echo 0 > $mntpoint/0/cpuset.mems 2> /dev/null
- fi
+ cgroup_regression_5_1.sh &
+ local pid1=$!
+ cgroup_regression_5_2.sh &
+ local pid2=$!
- sleep 100 &
- echo $! > $mntpoint/0/tasks
+ sleep 30
+ kill -USR1 $pid1 $pid2
+ wait $pid1 2>/dev/null
+ wait $pid2 2>/dev/null
- kill -TERM $! > /dev/null
- wait $! 2>/dev/null
- rmdir $mntpoint/0
- # Do NOT unmount pre-existent mountpoints...
- [ -z "$mounted" ] && umount $mntpoint/
+ mount -t cgroup none cgroup 2> /dev/null
+ mkdir cgroup/0
+ rmdir cgroup/0
+ umount cgroup/ 2> /dev/null
check_kernel_bug
}
@@ -488,30 +439,4 @@ test9()
check_kernel_bug
}
-#---------------------------------------------------------------------------
-# Bug: When running 2 concurrent mount/umount threads, kernel WARNING
-# may be triggered, but it's VFS' issue but not cgroup.
-# Kernel: 2.6.24 - 2.6.29-rcX
-# Links: http://lkml.org/lkml/2009/1/4/354
-# Fix: commit 1a88b5364b535edaa321d70a566e358390ff0872
-#---------------------------------------------------------------------------
-test10()
-{
- cgroup_regression_10_1.sh &
- local pid1=$!
- cgroup_regression_10_2.sh &
- local pid2=$!
-
- sleep 30
- kill -USR1 $pid1 $pid2
- wait $pid1 2>/dev/null
- wait $pid2 2>/dev/null
-
- mount -t cgroup none cgroup 2> /dev/null
- mkdir cgroup/0
- rmdir cgroup/0
- umount cgroup/ 2> /dev/null
- check_kernel_bug
-}
-
tst_run
--
2.18.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [LTP] [PATCH v2] cgroup_regression_test.sh: Remove obselte test_5
2019-09-19 10:38 ` [LTP] [PATCH v2] " Yang Xu
@ 2019-09-19 14:09 ` Petr Vorel
2019-09-20 1:19 ` Yang Xu
0 siblings, 1 reply; 7+ messages in thread
From: Petr Vorel @ 2019-09-19 14:09 UTC (permalink / raw)
To: ltp
Hi Xu,
> test_5 is a very old regresstion test and kernel code has been
> rewritten completely since 2.6. No user will use such old kernel
> code to test. So I think we can remove it.
> Also rename test10 as test5, modify TST_CNT.
Merged, with additional note, why it's safe to remove it:
[ pvorel: test_5 is testing 839ec5452ebf ("cgroup: fix root_count when
mount fails due to busy subsystem") from v2.6.29-rc4 which fixes
e5f6a8609bab ("cgroups: make root_list contains active hierarchies
only") from v2.6.24-rc1. While there are still people testing LTP on
2.6.x, nobody should be using -rc version now. ]
Kind regards,
Petr
^ permalink raw reply [flat|nested] 7+ messages in thread* [LTP] [PATCH v2] cgroup_regression_test.sh: Remove obselte test_5
2019-09-19 14:09 ` Petr Vorel
@ 2019-09-20 1:19 ` Yang Xu
2019-09-23 10:02 ` Petr Vorel
0 siblings, 1 reply; 7+ messages in thread
From: Yang Xu @ 2019-09-20 1:19 UTC (permalink / raw)
To: ltp
on 2019/09/19 22:09, Petr Vorel wrote:
> Hi Xu,
>
>> test_5 is a very old regresstion test and kernel code has been
>> rewritten completely since 2.6. No user will use such old kernel
>> code to test. So I think we can remove it.
>
>> Also rename test10 as test5, modify TST_CNT.
>
> Merged, with additional note, why it's safe to remove it:
>
> [ pvorel: test_5 is testing 839ec5452ebf ("cgroup: fix root_count when
> mount fails due to busy subsystem") from v2.6.29-rc4 which fixes
> e5f6a8609bab ("cgroups: make root_list contains active hierarchies
> only") from v2.6.24-rc1. While there are still people testing LTP on
> 2.6.x, nobody should be using -rc version now. ]
I think your wrote v2.6.24-rc1 unexpectedly. commit e5f6a8609bab fixes
the bug since v2.6.29-rc1 not v2.6.24-rc1. In addition to this typo,
this reason looks good to me.
>
> Kind regards,
> Petr
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [LTP] [PATCH v2] cgroup_regression_test.sh: Remove obselte test_5
2019-09-20 1:19 ` Yang Xu
@ 2019-09-23 10:02 ` Petr Vorel
0 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2019-09-23 10:02 UTC (permalink / raw)
To: ltp
Hi Xu,
> > Merged, with additional note, why it's safe to remove it:
> > [ pvorel: test_5 is testing 839ec5452ebf ("cgroup: fix root_count when
> > mount fails due to busy subsystem") from v2.6.29-rc4 which fixes
> > e5f6a8609bab ("cgroups: make root_list contains active hierarchies
> > only") from v2.6.24-rc1. While there are still people testing LTP on
> > 2.6.x, nobody should be using -rc version now. ]
> I think your wrote v2.6.24-rc1 unexpectedly. commit e5f6a8609bab fixes the
> bug since v2.6.29-rc1 not v2.6.24-rc1. In addition to this typo, this reason
> looks good to me.
Thanks for info, unfortunately too late, git already has wrong kernel version in
the commit message. Sorry for an error.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-23 10:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-19 9:10 [LTP] [PATCH] cgroup_regression_test.sh: Remove obselte test_5 Yang Xu
2019-09-19 9:45 ` Cyril Hrubis
2019-09-19 9:54 ` Yang Xu
2019-09-19 10:38 ` [LTP] [PATCH v2] " Yang Xu
2019-09-19 14:09 ` Petr Vorel
2019-09-20 1:19 ` Yang Xu
2019-09-23 10:02 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox