[LTP] [PATCH v2] cgroup_regression_test.sh: Remove obselte test_5

Yang Xu
2019-09-20T01:19:10Z

on 2019/09/19 22:09, Petr Vorel wrote:
> Hi Xu,
>
>> test_5 is a very old regresstion test and kernel code has been
>> rewritten completely since 2.6. No user will use such old kernel
>> code to test. So I think we can remove it.
>
>> Also rename test10 as test5, modify TST_CNT.
>
> Merged, with additional note, why it's safe to remove it:
>
> [ pvorel: test_5 is testing 839ec5452ebf ("cgroup: fix root_count when
> mount fails due to busy subsystem") from v2.6.29-rc4 which fixes
> e5f6a8609bab ("cgroups: make root_list contains active hierarchies
> only") from v2.6.24-rc1. While there are still people testing LTP on
> 2.6.x, nobody should be using -rc version now. ]
I think your wrote v2.6.24-rc1 unexpectedly. commit e5f6a8609bab fixes
the bug since v2.6.29-rc1 not v2.6.24-rc1. In addition to this typo,
this reason looks good to me.

>
> Kind regards,
> Petr
>
>