From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] timer_create01: accept ENOTSUP
Date: Fri, 27 Sep 2019 16:54:07 +0200 [thread overview]
Message-ID: <20190927145407.GE17233@rei.lan> (raw)
In-Reply-To: <20190927145316.GA8472@calabresa>
Hi!
> > > CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM require an RTC with alarm
> > > support, which may not be present on a system. In that case, the kernel
> > > will return EOPNOTSUPP, which is defined as ENOTSUP in userspace.
> > >
> > > As these clocks are already possibly unsupported, accept that as an error
> > > code besides the EINVAL code.
> > >
> > > Note that previously the kernel would incorrectly return the ENOTSUPP code,
> > > which is undefined in userspace. With these unfixed kernels, the test will
> > > fail when those RTCs are not present.
> >
> > Can you please include the kernel commit id that fixed the kernel here?
> >
> > Otherwise this patch is fine.
>
> f18ddc13af981ce3c7b7f26925f099e7c6929aba ("alarmtimer: Use EOPNOTSUPP instead of ENOTSUPP")
>
> Do you want me to send a v2, or will you fixup the patch?
No need, I will add that info, thanks.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-09-27 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 14:45 [LTP] [PATCH] timer_create01: accept ENOTSUP Thadeu Lima de Souza Cascardo
2019-09-27 14:49 ` Cyril Hrubis
2019-09-27 14:53 ` Thadeu Lima de Souza Cascardo
2019-09-27 14:54 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927145407.GE17233@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox