From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/copy_file_range02: skip if cross-fs isn't supported
Date: Mon, 30 Sep 2019 11:24:33 +0200 [thread overview]
Message-ID: <20190930092432.GA17643@rei.lan> (raw)
In-Reply-To: <20190927121528.31888-1-pvorel@suse.cz>
Hi!
> +static inline int verify_cross_fs_copy_support(void)
> +{
> + int i, fd, fd_test;
> +
> + if (!test.mount_device)
> + tst_brk(TBROK, "using %s() requires setting .mount_device = 1", __func__);
> +
> + if (strcmp(test.mntpoint, MNTPOINT))
> + tst_brk(TBROK, "using %s() requires setting .mntpoint = MNTPOINT ('%s')",
> + __func__, test.mntpoint);
Can we please pass the source and destination as parameters to this
function instead of depending on very speical setup like this?
Also this is a last patch I do consider for the release, I will tag the
git once this is sorted out.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-09-30 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 12:15 [LTP] [PATCH] syscalls/copy_file_range02: skip if cross-fs isn't supported Petr Vorel
2019-09-30 9:24 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930092432.GA17643@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox