From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] pkeys: Fix uclibc build caused by conflicting signature
Date: Wed, 2 Oct 2019 12:36:58 +0200 [thread overview]
Message-ID: <20191002103658.GA8087@dell5510> (raw)
In-Reply-To: <1944770230.3074247.1570003394396.JavaMail.zimbra@redhat.com>
Hi Jan,
> ----- Original Message -----
> > Removing static fixes the problem.
> I'd prefer we rename test functions:
> #ifndef HAVE_PKEY_MPROTECT
> static inline int my_pkey_alloc()
> #else
> #define my_pkey_alloc pkey_alloc
> #endif
> my_pkey_alloc()
Good idea, thanks. I'd a detail, I'd prefer to use 'ltp_' prefix (ltp_pkey_alloc()).
Kind regards,
Petr
prev parent reply other threads:[~2019-10-02 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 18:47 [LTP] [PATCH] pkeys: Fix uclibc build caused by conflicting signature Petr Vorel
2019-10-02 8:03 ` Jan Stancek
2019-10-02 10:36 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002103658.GA8087@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox