From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 2/2] doc: Add user-guide.txt
Date: Fri, 4 Oct 2019 15:21:35 +0200 [thread overview]
Message-ID: <20191004132129.GE5442@rei.lan> (raw)
In-Reply-To: <20191003164347.GA2061@dell5510>
Hi!
> > > ```
> > > -$ LTPROOT=/opt/ltp PATH="$PATH:$LTPROOT/testcases/bin" testcases/bin/wc01.sh
> > > +$ LTPROOT=/opt/ltp PATH="$PATH:$LTPROOT/bin:$LTPROOT/testcases/bin" testcases/bin/wc01.sh
> > > ```
>
> > This looks like an unrelated change at best and should probably be part
> > of a separate patch.
>
> > Also the only thing that seems to be installed in $LTPROOT/bin/ that
> > could be potentially used by tests is the ffsb tool, that we are going
> > to get rid anyways. So I would have avoided including it in the example
> > anyways.
>
> Yep, I'm aware ffsb is needed from $LTPROOT/bin. I haven't forced to send
> proposal about ffbs adding into separate repository, that why I included it.
> But sure, I'll drop this part.
> Ack the rest?
Yes, the rest is fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-10-04 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 11:58 [LTP] [RFC PATCH 0/2] Update user related docs Petr Vorel
2019-09-30 11:58 ` [LTP] [RFC PATCH 1/2] doc: Removed outdated ltp-howto.{txt,lyx} Petr Vorel
2019-10-03 11:35 ` [LTP] [RFC PATCH 1/2] doc: Removed outdated ltp-howto.{txt, lyx} Cyril Hrubis
2019-09-30 11:58 ` [LTP] [RFC PATCH 2/2] doc: Add user-guide.txt Petr Vorel
2019-10-03 11:44 ` Cyril Hrubis
2019-10-03 16:43 ` Petr Vorel
2019-10-04 13:21 ` Cyril Hrubis [this message]
2019-10-04 17:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004132129.GE5442@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox