From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] getdents: Fix build under glibc 2.30
Date: Tue, 8 Oct 2019 13:02:43 +0200 [thread overview]
Message-ID: <20191008110243.GA23860@dell5510> (raw)
In-Reply-To: <20191008105025.GB9170@rei.lan>
Hi Cyril,
> > glibc commit b8b3d5a14e ("Linux: Move getdents64 to <dirent.h>")
> > moved the declaration from <unistd.h> to <dirent.h> to match the
> > location of the declaration in musl.
> > Thus we need to include both <dirent.h> and <unistd.h> for getdents64().
> > Using getdents64() declaration requires on both glibc and musl
> > _GNU_SOURCE definition, thus move it to to getdents.h.
> I would rather go for _GNU_SOURCE being defined in the testcases rather
> than hiding it in the getdenst.h header and depending on the order.
> Other than that it's fine.
Make sense. Thanks for a review, merged with this change.
Kind regards,
Petr
prev parent reply other threads:[~2019-10-08 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:32 [LTP] [PATCH] getdents: Fix build under glibc 2.30 Petr Vorel
2019-10-08 10:50 ` Cyril Hrubis
2019-10-08 11:02 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008110243.GA23860@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox