From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] controllers/cgroup_regression_test.sh: mitigate potential mount error
Date: Tue, 8 Oct 2019 16:19:57 +0200 [thread overview]
Message-ID: <20191008141956.GA17636@rei.lan> (raw)
In-Reply-To: <d9f667f7-f836-8918-2a3a-180e37c9e2a0@linux.alibaba.com>
Hi!
> > There is always better solution than sprinking the code with sleeps,
> > here we can retry the mount instead, which would be faster and more
>
> thanks for your kind reply!
>
> retry mount cannot help here(at least for the current kernel), because
> `umount cgroup/` **immediately** after `rmdir cgroup/0` corrupts the
> cgroup_root refcnt, and it will always cause the subsequent remount
> failure(s) whenever remounting overlapping controllers later.
>
> so I simply put a sleep between between `umount cgroup/` and `rmdir
> cgroup/0` to synchronize them. <- any good idea to this point?
>
> and attach the related kernel issue again:
> https://marc.info/?t=155021167400005&r=1&w=2
We are not working around kernel bugs in tests.
Too bad that it seems that nobody is interested in fixing the v1 cgroup
API. I guess this is a signal that we should stop using it as fast as
possible and migrate to v2.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-10-08 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 6:10 [LTP] [PATCH] controllers/cgroup_regression_test.sh: mitigate potential mount error Xu Yu
2019-04-04 9:10 ` Cyril Hrubis
2019-04-10 7:04 ` Yu Xu
2019-10-08 14:19 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008141956.GA17636@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox