* [LTP] [PATCH] ext4-new-features: Fix paths to ffsb-config files
@ 2019-10-09 6:21 Joerg Vehlow
2019-10-09 7:47 ` Petr Vorel
0 siblings, 1 reply; 2+ messages in thread
From: Joerg Vehlow @ 2019-10-09 6:21 UTC (permalink / raw)
To: ltp
From: Joerg Vehlow <joerg.vehlow@aox-tech.de>
The path to the ffsb-config files was just plain wrong (they are copied to
$LTPROOT/testcases/data/ext4-ffsb, but searched in cwd.
This is the same fix as in 4ae5699d, only for other tests.
Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
---
.../ext4-journal-checksum/ext4_journal_checksum.sh | 2 +-
.../ext4-uninit-groups/ext4_uninit_groups_test.sh | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/ext4_journal_checksum.sh b/testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/ext4_journal_checksum.sh
index 9edb89397..822c94a8c 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/ext4_journal_checksum.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/ext4_journal_checksum.sh
@@ -69,7 +69,7 @@ ext4_test_journal_checksum()
return
fi
- ffsb ffsb-config2 > /dev/null
+ ffsb $LTPROOT/testcases/data/ext4-ffsb/ffsb-config2 > /dev/null
if [ $? -ne 0 ]; then
tst_resm TFAIL "ffsb returned failure"
umount mnt_point
diff --git a/testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/ext4_uninit_groups_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/ext4_uninit_groups_test.sh
index d39afae56..cf4c354d9 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/ext4_uninit_groups_test.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/ext4_uninit_groups_test.sh
@@ -34,13 +34,13 @@ age_filesystem()
{
if [ $1 -eq $EMPTY ]; then
# aging, then del
- ffsb ffsb-config3 > /dev/null
+ ffsb $LTPROOT/testcases/data/ext4-ffsb/ffsb-config3 > /dev/null
rm -rf mnt_point/*
elif [ $1 -eq $SMALL ]; then
# age filesystem from 0.0 to 0.2 -> 0.4 -> 0.6 -> 0.8 -> 1.0
for ((n = 3; n < 8; n++))
{
- ffsb ffsb-config$n > /dev/null
+ ffsb $LTPROOT/testcases/data/ext4-ffsb/ffsb-config$n > /dev/null
mv mnt_point/data mnt_point/data$n
}
elif [ $1 -eq $LARGE ]; then
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [LTP] [PATCH] ext4-new-features: Fix paths to ffsb-config files
2019-10-09 6:21 [LTP] [PATCH] ext4-new-features: Fix paths to ffsb-config files Joerg Vehlow
@ 2019-10-09 7:47 ` Petr Vorel
0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2019-10-09 7:47 UTC (permalink / raw)
To: ltp
Hi Joerg,
> The path to the ffsb-config files was just plain wrong (they are copied to
> $LTPROOT/testcases/data/ext4-ffsb, but searched in cwd.
> This is the same fix as in 4ae5699d, only for other tests.
> Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
> ---
> .../ext4-journal-checksum/ext4_journal_checksum.sh | 2 +-
> .../ext4-uninit-groups/ext4_uninit_groups_test.sh | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Thanks for your patch.
ext4_online_defrag_test.sh still contains wrong path.
I'd prefer to introduce some variable in ext4_funcs.sh, e.g.:
FFSB_CONFIG_DIR="$LTPROOT/testcases/data/ext4-ffsb"
Kind regards,
Petr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-09 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 6:21 [LTP] [PATCH] ext4-new-features: Fix paths to ffsb-config files Joerg Vehlow
2019-10-09 7:47 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox