From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] tst_test.sh: Add public tst_test_root command
Date: Wed, 9 Oct 2019 13:48:54 +0200 [thread overview]
Message-ID: <20191009114854.GC7561@rei.lan> (raw)
In-Reply-To: <64bb824c-d577-86e5-bfa5-17a8cfbf4174@jv-coder.de>
Hi!
> > Can we keep the name to be tst_require_root() please?
> >
> > Historically this function has been always named like this in LTP.
> >
> Not a very good argument for two reasons:
> 1. The function was internal to the library, so no one (except for
> library developers)
It has been in a public API for the old library for more than ten years
before the new library was written.
> 2. I wanted to make it consistent with other functions, that do similar
> stuff like
> ???? tst_test_drivers and tst_test_cmds. Both also call tst_brk in case
> of unsuccessful tests.
Well I do not like these names either, it's less descriptive that it
would have been with tst_require_cmds and tst_require_drivers, so if
anything I would be for renaming the tst_test_* ones.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-10-09 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 6:16 [LTP] Add TST_USES_MODULE and tst_test_root Joerg Vehlow
2019-10-09 6:16 ` [LTP] [PATCH 1/2] tst_test.sh: Add TST_USES_MODULE Joerg Vehlow
2019-10-09 7:36 ` Petr Vorel
2019-10-09 7:48 ` Joerg Vehlow
2019-10-09 6:16 ` [LTP] [PATCH 2/2] tst_test.sh: Add public tst_test_root command Joerg Vehlow
2019-10-09 6:52 ` Petr Vorel
2019-10-09 6:57 ` Joerg Vehlow
2019-10-09 7:53 ` Petr Vorel
2019-10-09 11:39 ` Cyril Hrubis
2019-10-09 11:43 ` Joerg Vehlow
2019-10-09 11:48 ` Cyril Hrubis [this message]
2019-10-09 11:53 ` Joerg Vehlow
2019-10-09 12:28 ` Cyril Hrubis
2019-10-11 8:36 ` Petr Vorel
2019-10-11 8:39 ` Joerg Vehlow
2019-10-11 8:20 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009114854.GC7561@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox