From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] acct: fix version check on big endian system
Date: Thu, 10 Oct 2019 13:36:26 +0200 [thread overview]
Message-ID: <20191010113626.GA23153@dell5510> (raw)
In-Reply-To: <CAEemH2e-ASzAAPgkh2JFn8qZLgAL=2em5kZWk=2G0CYrAnuMAg@mail.gmail.com>
Hi Li, Ping, Cyril,
> On Thu, Oct 10, 2019 at 4:33 PM Li Wang <liwan@redhat.com> wrote:
> > Ping Fang <pifang@redhat.com> wrote:
> > ac_version = ACCT_VERION | ACCT_BYTEORDER
> >> which is 0x83 (131) on big endian system.
> >> failure output:
> >> tst_kconfig.c:62: INFO: Parsing kernel config
> >> '/boot/config-4.18.0-147.el8.s390x'
> >> tst_test.c:1118: INFO: Timeout per run is 0h 05m 00s
> >> tst_kconfig.c:62: INFO: Parsing kernel config
> >> '/boot/config-4.18.0-147.el8.s390x'
> >> acct02.c:239: INFO: Verifying using 'struct acct_v3'
> >> acct02.c:192: INFO: == entry 1 ==
> >> acct02.c:147: INFO: ac_version != 3 (131)
> >> acct02.c:192: INFO: == entry 2 ==
> >> acct02.c:82: INFO: ac_comm != 'acct02_helper' ('acct02')
> >> acct02.c:133: INFO: ac_exitcode != 32768 (0)
> >> acct02.c:141: INFO: ac_ppid != 34501 (34500)
> >> acct02.c:147: INFO: ac_version != 3 (131)
> >> acct02.c:182: FAIL: end of file reached
> > I'm wondering that is there any necessary to use do{}...while loop for
> > entry many times? Since the verify_acct() only check the dummy
> > program(acct02_helper) accounting struct. So in the error logs, we could
> > see some meaningless data(acct02) in entry 2.
> It turns out I was wrong, if accounting is turned on, system records for
> each terminating process but not only for that process, so we need to pick
> up the correct acct_struct in acct_file via the while loop.
> Sorry for making noise, I pull back my comments here.
Thanks for a fix, merged.
Petr
next prev parent reply other threads:[~2019-10-10 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 8:17 [LTP] [PATCH v2] acct: fix version check on big endian system Ping Fang
2019-10-10 8:33 ` Li Wang
2019-10-10 9:13 ` Li Wang
2019-10-10 11:36 ` Petr Vorel [this message]
2019-10-10 11:06 ` Cyril Hrubis
2019-10-10 11:39 ` Petr Vorel
2019-10-10 11:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010113626.GA23153@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox