public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v4 3/5] shell: Add timeout shell API tests
Date: Fri, 11 Oct 2019 10:17:35 +0200	[thread overview]
Message-ID: <20191011081735.GB31207@dell5510> (raw)
In-Reply-To: <20191009143635.GF7561@rei.lan>

Hi Cyril,

> > +DATA="
> > +timeout01.sh||0
> > +timeout02.sh||0
> > +timeout02.sh|foo|32
> > +timeout02.sh|2|0
> > +timeout02.sh|1.1|0
> > +timeout02.sh|-10|32
> > +"
> > +
> > +echo "Testing timeout in shell API"
> > +echo
> > +
> > +failed=0
> > +IFS="
> > +"

> Do we have to change IFS here? It should be set to space, tab, and
> newline by default, so the loop over $DATA should work correctly
> anyways.
Again, thanks for catching this.
It's a left over from prototyping, where I had spaces in some data rows,
therefore it was needed.

> > +for i in $DATA; do
> > +	file=$(echo $i | cut -d'|' -f1)
> > +	timeout=$(echo $i | cut -d'|' -f2)
> > +	exp_exit=$(echo $i | cut -d'|' -f3)

Unless you want me to do else with tst_test_cmds in tst_test.sh,
I'll merge with changes you found.

Kind regards,
Petr

  reply	other threads:[~2019-10-11  8:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30 14:59 [LTP] [RFC PATCH v4 0/5] shell: Introduce TST_TIMEOUT variable Petr Vorel
2019-09-30 14:59 ` [LTP] [RFC PATCH v4 1/5] shell: Add tst_is_num() Petr Vorel
2019-09-30 14:59 ` [LTP] [RFC PATCH v4 2/5] shell: Introduce TST_TIMEOUT variable, add checks Petr Vorel
2019-10-09 14:34   ` Cyril Hrubis
2019-10-11  8:12     ` Petr Vorel
2019-09-30 14:59 ` [LTP] [RFC PATCH v4 3/5] shell: Add timeout shell API tests Petr Vorel
2019-10-02 10:46   ` Petr Vorel
2019-10-09 14:36   ` Cyril Hrubis
2019-10-11  8:17     ` Petr Vorel [this message]
2019-09-30 14:59 ` [LTP] [RFC PATCH v4 4/5] memcg_stress_test.sh: use TST_TIMEOUT (replace LTP_TIMEOUT_MUL) Petr Vorel
2019-09-30 14:59 ` [LTP] [RFC PATCH v4 5/5] net/if-mtu-change.sh: set TST_TIMEOUT Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011081735.GB31207@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox