public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Rename tst_test_* to tst_require_*
Date: Fri, 11 Oct 2019 12:06:06 +0200	[thread overview]
Message-ID: <20191011100604.GA11441@dell5510> (raw)
In-Reply-To: <20191011090737.17997-1-lkml@jv-coder.de>

Hi,

Cc: Li and Clemens

> these patches rename tst_test_* to tst_require_*, to better describe
> their use. There is also tst_require_root, that has the same
> behavior: It also calls tst_brk in case of a failing requirement.

> You can also get this patch from the following repo:
> https://github.com/MofX/ltp/commits/rename_tst_test-tst_require

sorry for not thinking first, I wonder if we want to sync
tst_test_* (function name) vs $TST_NEEDS_* (test API variable name),
e.g.: tst_require_drivers $TST_NEEDS_DRIVERS

i.e. either of these:
s/tst_test_/tst_needs_/
s/TST_NEEDS_/TST_REQUIRE_/

I consider *require* as more descriptive than *needs*,
but changing to *require* would require more work :).

Kind regards,
Petr

  parent reply	other threads:[~2019-10-11 10:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11  9:07 [LTP] Rename tst_test_* to tst_require_* Joerg Vehlow
2019-10-11  9:07 ` [LTP] [PATCH 1/2] shell: Rename s/tst_test_cmds/tst_require_cmds/ Joerg Vehlow
2019-10-11  9:07 ` [LTP] [PATCH 2/2] shell: Rename s/tst_test_drivers/tst_require_drivers/ Joerg Vehlow
2019-10-11 10:06 ` Petr Vorel [this message]
2019-10-11 12:36   ` [LTP] Rename tst_test_* to tst_require_* Cyril Hrubis
2019-10-11 13:03   ` Clemens Famulla-Conrad
2019-10-11 13:10     ` Cyril Hrubis
2019-10-11 14:00       ` Petr Vorel
2019-10-24 12:28         ` Cyril Hrubis
2019-10-24 12:48           ` Petr Vorel
2019-11-06 16:26             ` Cyril Hrubis
2019-11-06 17:01               ` Petr Vorel
2019-11-07 11:09                 ` Petr Vorel
2019-11-07 11:32               ` Petr Vorel
2019-10-11 13:28     ` Li Wang
2019-10-11 13:39     ` Joerg Vehlow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011100604.GA11441@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox