From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 0/5] shell: Introduce TST_TIMEOUT variable
Date: Fri, 11 Oct 2019 14:06:34 +0200 [thread overview]
Message-ID: <20191011120633.GC2591@rei> (raw)
In-Reply-To: <20191011095442.10541-1-pvorel@suse.cz>
Hi!
> Changes v4->v5:
> * remove float related code (left from v3)
> * remove "tst_test_cmds cut" check from tst_test.sh (there is check for
> cut and other later => it should be probably removed as well, but as a
> separate patch) (Cyril)
> * remove unneeded IFS from test (Cyril)
> * mention ceiling LTP_TIMEOUT_MUL in doc/user-guide.txt
>
> Here is the diff:
> diff --git doc/user-guide.txt doc/user-guide.txt
> index 8913c3221..7f6334ec2 100644
> --- doc/user-guide.txt
> +++ doc/user-guide.txt
> @@ -15,7 +15,7 @@ For running LTP network tests see `testcases/network/README.md`.
> 'n' or '0': never colorize.
> | 'LTP_TIMEOUT_MUL' | Multiply timeout, must be number >= 1 (> 1 is useful for
> slow machines to avoid unexpected timeout).
> - Variable is also used in shell tests.
> + Variable is also used in shell tests, but here ceiled to int.
^
Drop
the
"here"
Other than that it's fine, you can add my Reviewed-by:
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-10-11 12:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 9:54 [LTP] [PATCH v5 0/5] shell: Introduce TST_TIMEOUT variable Petr Vorel
2019-10-11 9:54 ` [LTP] [PATCH v5 1/5] shell: Add tst_is_num() Petr Vorel
2019-10-11 9:54 ` [LTP] [PATCH v5 2/5] shell: Introduce TST_TIMEOUT variable, add checks Petr Vorel
2019-10-11 9:54 ` [LTP] [PATCH v5 3/5] shell: Add timeout shell API tests Petr Vorel
2019-10-11 12:36 ` Clemens Famulla-Conrad
2019-10-11 12:54 ` Petr Vorel
2019-10-11 12:56 ` Cyril Hrubis
2019-10-11 13:31 ` Petr Vorel
2019-10-11 14:02 ` Cyril Hrubis
2019-10-12 9:55 ` Li Wang
2019-10-14 8:47 ` Petr Vorel
2019-10-14 8:08 ` Clemens Famulla-Conrad
2019-10-14 8:46 ` Petr Vorel
2019-10-11 9:54 ` [LTP] [PATCH v5 4/5] memcg_stress_test.sh: use TST_TIMEOUT (replace LTP_TIMEOUT_MUL) Petr Vorel
2019-10-11 9:54 ` [LTP] [PATCH v5 5/5] net/if-mtu-change.sh: set TST_TIMEOUT Petr Vorel
2019-10-11 12:06 ` Cyril Hrubis [this message]
2019-10-11 12:39 ` [LTP] [PATCH v5 0/5] shell: Introduce TST_TIMEOUT variable Clemens Famulla-Conrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011120633.GC2591@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox