From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 5/5] Adopt doc for TST_RETRY_FUNC for LTP_TIMEOUT_MUL
Date: Mon, 21 Oct 2019 15:53:46 +0200 [thread overview]
Message-ID: <20191021135345.GA8999@x230> (raw)
In-Reply-To: <1571665264.4633.8.camel@suse.de>
Hi Clemens,
> > Isn't it meant to be used just in library (in lib/tst_test.c)?
> > Thus I wouldn't document it here. And in fact remove it from
> > include/tst_test.h
> > (second commit).
> I'm ok with private function. But you need to make it available to
> tst_common.h. We could use extern. But not sure if this is what we
> want.
> On the other hand, we could make it as lib function, so others, who
> need to set timeout in arbitrary way, have a utility to adjust there
> timeout in a generic way. WDYT? But we also could leave this for later,
> and simply change it if really needed.
Well, it's not that important to complicate things.
My point was, that function is used only internally, unlike tst_set_timeout()
and tst_timeout_remaining() which are also used in some tests.
> Thanks
> Clemens
Kind regards,
Petr
next prev parent reply other threads:[~2019-10-21 13:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 12:44 [LTP] [PATCH v4 0/5] tst_test.sh: Use LTP_TIMEOUT_MUL in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 1/5] " Clemens Famulla-Conrad
2019-10-21 12:42 ` Petr Vorel
2019-10-21 14:18 ` Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 2/5] tst_test.c: Add tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 12:50 ` Petr Vorel
2019-10-21 14:17 ` Clemens Famulla-Conrad
2019-10-21 14:42 ` Petr Vorel
2019-10-22 13:14 ` Petr Vorel
2019-10-21 14:37 ` Cyril Hrubis
2019-10-21 15:31 ` Clemens Famulla-Conrad
2019-10-21 18:08 ` Petr Vorel
2019-10-18 12:45 ` [LTP] [PATCH v4 3/5] tst_common.h: Use tst_multiply_timeout in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-21 14:38 ` Cyril Hrubis
2019-10-18 12:45 ` [LTP] [PATCH v4 4/5] Add newlib shell test for tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 9:28 ` Li Wang
2019-10-22 8:08 ` Petr Vorel
2019-10-22 12:31 ` Clemens Famulla-Conrad
2019-10-18 12:45 ` [LTP] [PATCH v4 5/5] Adopt doc for TST_RETRY_FUNC for LTP_TIMEOUT_MUL Clemens Famulla-Conrad
2019-10-21 9:41 ` Richard Palethorpe
2019-10-21 13:15 ` Petr Vorel
2019-10-21 13:41 ` Clemens Famulla-Conrad
2019-10-21 13:53 ` Petr Vorel [this message]
2019-10-21 14:46 ` Cyril Hrubis
2019-10-21 18:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021135345.GA8999@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).