From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] lib: Add support for test tags
Date: Tue, 22 Oct 2019 16:19:46 +0200 [thread overview]
Message-ID: <20191022141946.GA16121@dell5510> (raw)
In-Reply-To: <20191022140757.29713-2-chrubis@suse.cz>
Hi Cyril,
> + fprintf(stderr, "Options\n");
> + fprintf(stderr, "-------\n\n");
I still would remove this extra new line:
fprintf(stderr, "-------\n");
> +
> for (i = 0; i < ARRAY_SIZE(options); i++)
> fprintf(stderr, "%s\n", options[i].help);
> @@ -424,6 +430,28 @@ static void print_help(void)
> fprintf(stderr, "%s\n", tst_test->options[i].help);
> }
> +static void print_test_tags(void)
> +{
> + unsigned int i;
> + const struct tst_tag *tags = tst_test->tags;
> +
> + printf("\nTags\n");
> + printf("----\n\n");
And here:
printf("----\n");
Otherwise LGTM.
Kind regards,
Petr
next prev parent reply other threads:[~2019-10-22 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 14:07 [LTP] [PATCH v2 0/2] Add support for a test tags Cyril Hrubis
2019-10-22 14:07 ` [LTP] [PATCH v2 1/2] lib: Add support for " Cyril Hrubis
2019-10-22 14:19 ` Petr Vorel [this message]
2019-11-06 15:26 ` Cyril Hrubis
2019-10-23 7:39 ` Li Wang
2019-10-23 7:58 ` Jan Stancek
2019-10-23 8:06 ` Li Wang
2019-10-23 16:06 ` Cyril Hrubis
2019-10-24 2:45 ` Li Wang
2019-10-22 14:07 ` [LTP] [PATCH v2 2/2] testcases/kernel: Add linux git and CVE tags Cyril Hrubis
2019-10-23 7:18 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022141946.GA16121@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox