From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] pt_test: skip pt_disable_branch on Broadwell CPUs
Date: Fri, 1 Nov 2019 08:12:44 +0100 [thread overview]
Message-ID: <20191101071244.GA4930@dell5510> (raw)
In-Reply-To: <a5174e749dd7b6089fa861b5369baf9f80c51ef8.1572269566.git.jstancek@redhat.com>
Hi Jan,
> commit d35869ba348d ("perf/x86/intel/pt: Allow the disabling of branch tracing")
> disallows not setting BRANCH_EN due to erratum BDM106 on Broadwell CPUs.
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> @@ -145,6 +171,11 @@ static void setup(void)
> attr.size = sizeof(struct perf_event_attr);
> attr.mmap = 1;
> if (str_branch_flag) {
> + if (is_affected_by_erratum_BDM106()) {
> + tst_brk(TCONF, "erratum BDM106 disallows not "
> + "setting BRANCH_EN on this CPU");
I'd join string (to be on single line), even it's longer than 80.
(better for grep)
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-01 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 13:33 [LTP] [PATCH] pt_test: skip pt_disable_branch on Broadwell CPUs Jan Stancek
2019-11-01 7:12 ` Petr Vorel [this message]
2019-11-04 15:55 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101071244.GA4930@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox