From: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] cgroup_fj_stress: Avoid killall
Date: Tue, 5 Nov 2019 12:20:00 +0100 [thread overview]
Message-ID: <20191105112000.20633-1-cfamullaconrad@suse.de> (raw)
We discovered problems that killall didn't catched all processes. With
this patch, we collect the pids manually and kill them one after the
other.
Signed-off-by: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
---
testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
index 698aa4979..27ea7634a 100755
--- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
+++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
@@ -74,6 +74,7 @@ setup
export TMPFILE=./tmp_tasks.$$
count=0
+collected_pids=""
build_subgroups()
{
@@ -107,6 +108,7 @@ attach_task()
if [ -z "$ppid" ]; then
cgroup_fj_proc&
pid=$!
+ collected_pids="$collected_pids $pid"
else
pid="$ppid"
fi
@@ -148,9 +150,10 @@ case $attach_operation in
"each" )
tst_resm TINFO "Attaching task to each subgroup"
attach_task "$start_path" 0
- ROD killall -9 "cgroup_fj_proc"
- # Wait for attached tasks to terminate
- wait
+ for pid in $collected_pids; do
+ ROD kill -9 "$pid"
+ wait "$pid"
+ done
;;
* )
;;
--
2.16.4
next reply other threads:[~2019-11-05 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 11:20 Clemens Famulla-Conrad [this message]
2019-11-05 13:20 ` [LTP] [PATCH v1] cgroup_fj_stress: Avoid killall Petr Vorel
2019-11-05 13:49 ` Clemens Famulla-Conrad
2019-11-06 17:12 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105112000.20633-1-cfamullaconrad@suse.de \
--to=cfamullaconrad@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox