From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] configure.ac: Fix --with* options
Date: Wed, 13 Nov 2019 17:02:54 +0100 [thread overview]
Message-ID: <20191113160254.GA28826@dell5510> (raw)
In-Reply-To: <20191113104149.42407-1-lkml@jv-coder.de>
Hi Joerg,
> From: Joerg Vehlow <joerg.vehlow@aox-tech.de>
> The usage of AC_ARG_WITH was wrong. This resulted in unexpected configuration.
> E.g --without-bash set with_bash=yes and --with-nume set with_numa=no.
> This is fixed by using "$withval" in the action-if-given. Also all AC_ARG_WITH
> are unified now (all use alos action-if-not-given)
> The "default=" help text did not make sense for same options.
> e.g. for --with expect was "default=yes", but it defaults to no.
> The "default=" strings are dropped, because defaultness is indicated by
> either "--with-<option>" or "--without-<option>" as done by other projects,
> that use autoconf.
> Defining AC_ARG_WITH within an if to express dependencies does not work.
> ./configure --with-realtime-testsuite set with_realtime_testsuite=yes,
> even if with_bash=no or with_python=no. The check is removed completely.
> Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
LGTM, but I'll have more deep look tomorrow.
FYI: https://github.com/linux-test-project/ltp/issues/508
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-13 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:41 [LTP] [PATCH] configure.ac: Fix --with* options Joerg Vehlow
2019-11-13 16:02 ` Petr Vorel [this message]
2019-11-14 3:24 ` Li Wang
2019-11-14 6:31 ` Joerg Vehlow
2019-11-14 7:59 ` Li Wang
2019-11-14 8:09 ` Joerg Vehlow
2019-11-14 8:36 ` Li Wang
2019-11-18 6:16 ` Petr Vorel
2019-11-18 6:38 ` Li Wang
2019-11-18 6:40 ` Joerg Vehlow
2019-11-18 8:59 ` Petr Vorel
2019-11-18 20:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113160254.GA28826@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox