Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] fanotify: Fix for musl
Date: Sun, 17 Nov 2019 11:04:01 +0100	[thread overview]
Message-ID: <20191117100401.GB22986@x230> (raw)
In-Reply-To: <977310824.12699736.1573924977430.JavaMail.zimbra@redhat.com>

Hi Jan,

> ----- Original Message -----
> > FSID_VAL_MEMBER() wrapper was meant to be only for struct
> > fanotify_event_info_fid, it was used also for struct event_t
> > (which has also __kernel_fsid_t fsid, but shouldn't be redefined).

> > This caused error on recent musl v1.1.23 (with f67b3c17),
> > which has struct fanotify_event_info_fid.

> > Fixes: 0498fc0a8 ("fanotify: Detect val vs. __val
> > fanotify_event_info_fid.fsid member")

> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>

> If it's needed for __kernel_fsid_t we'll need to come up with better names.
+1. But hope this is not needed.

> This basically reverts part of previous patch, which looks ok to me.
Yep. I'll add this to commit message, to be obvious.

> Acked-by: Jan Stancek <jstancek@redhat.com>

Thanks for your review.
I'll wait with merge till Monday (if Cyril has some comments).

Kind regards,
Petr

  reply	other threads:[~2019-11-17 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16  0:20 [LTP] [PATCH 1/1] fanotify: Fix for musl Petr Vorel
2019-11-16 17:22 ` Jan Stancek
2019-11-17 10:04   ` Petr Vorel [this message]
2019-11-18 20:33     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191117100401.GB22986@x230 \
    --to=petr.vorel@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox