From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/5] syscalls/quotactl01.c: Add Q_GETNEXQUOTA test
Date: Wed, 20 Nov 2019 18:09:48 +0100 [thread overview]
Message-ID: <20191120170948.GA7010@dell5510> (raw)
In-Reply-To: <989b7cbfa4cf4d7bb65c9b7df45b8c37@G08CNEXMBPEKD04.g08.fujitsu.local>
Hi Xu,
> >> TEST(quotactl(tc->cmd, tst_device->dev, *tc->id, tc->addr));
> >>+ if (TST_ERR == EINVAL) {
> >> + tst_res(TCONF, "Current system doesn't support this cmd");
> >nit: cmd? Maybe something like "quotactl() syscall does not support this command"
> >or "quotactl() syscall does not support to %s", tc->des to follow other messages. I'd actually prefer to have some macro, which prints QCMD flags, but that's a detail which we can >ignore.
> I think we can add some info before each run (such as prctl02.c and copy_file_range02.c, make error cases more clear ), as below:
> tst_res(TINFO, "Test #%d: %s", n, tc->tname); // this tname is a QCMD_string
+1. It could use similar approach as it's in testcases/kernel/syscalls/mbind/mbind01.c
#define POLICY_DESC(x) .policy = x, .desc = #x
#define POLICY_DESC_TEXT(x, y) .policy = x, .desc = #x" ("y")"
static struct test_case tcase[] = {
{
POLICY_DESC(MPOL_DEFAULT),
...
},
{
POLICY_DESC_TEXT(MPOL_DEFAULT, "target exists"),
But I'd prefer to have it as a separate patch after v4 of this patchset is merged.
I'd prefer to finish v4 (I've already fixed small formatting things, I can fix
the rest of needed things myself).
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-20 17:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:00 [LTP] [PATCH v2 0/6] optimize quotactl test code Yang Xu
2019-10-23 9:00 ` [LTP] [PATCH v2 1/6] syscalls/quotactl: Don't use ltp-quota.m4 Yang Xu
2019-10-31 14:02 ` Petr Vorel
2019-10-23 9:00 ` [LTP] [PATCH v2 2/6] m4/ltp-xfs_quota.m4: Remove useless ltp—xfs_quota.m4 Yang Xu
2019-10-31 15:26 ` Petr Vorel
2019-11-01 12:55 ` [LTP] [PATCH v3 0/5] optimize quotactl test code Yang Xu
2019-11-01 12:55 ` [LTP] [PATCH v3 1/5] syscalls/quotactl01.c: Add Q_GETNEXQUOTA test Yang Xu
2019-11-15 15:51 ` Petr Vorel
2019-11-18 6:42 ` Xu, Yang
2019-11-20 17:09 ` Petr Vorel [this message]
2019-11-21 3:59 ` Yang Xu
2019-11-15 16:48 ` Petr Vorel
2019-11-18 6:18 ` Xu, Yang
2019-11-18 6:24 ` Petr Vorel
2019-11-01 12:55 ` [LTP] [PATCH v3 2/5] syscalls/quotactl02.c: Add Q_XGETQSTATV test Yang Xu
2019-11-15 17:41 ` Petr Vorel
2019-11-18 7:59 ` Xu, Yang
2019-11-18 8:25 ` Petr Vorel
2019-11-01 12:55 ` [LTP] [PATCH v3 3/5] syscalls/quotactl04: add project quota test for non-xfs filesystem Yang Xu
2022-03-15 17:19 ` Petr Vorel
2022-03-16 2:00 ` xuyang2018.jy
2019-11-01 12:55 ` [LTP] [PATCH v3 4/5] syscalls/quotactl05: add project quota test for xfs filesystem Yang Xu
2019-11-01 12:55 ` [LTP] [PATCH v3 5/5] syscalls/quotactl06: Add new testcase Yang Xu
2019-11-12 8:05 ` [LTP] [PATCH v3 0/5] optimize quotactl test code Yang Xu
2019-11-15 9:02 ` Yang Xu
2019-11-15 9:25 ` Petr Vorel
2019-10-23 9:00 ` [LTP] [PATCH v2 3/6] syscalls/quotactl01.c: Add Q_GETNEXQUOTA test Yang Xu
2019-10-24 8:25 ` Jan Kara
2019-10-25 8:49 ` Yang Xu
2019-10-31 14:10 ` Petr Vorel
2019-10-31 14:31 ` Petr Vorel
2019-11-01 12:44 ` Yang Xu
2019-10-23 9:00 ` [LTP] [PATCH v2 4/6] syscalls/quotactl02.c: Add Q_XGETQSTATV and Q_XQUOTARM test Yang Xu
2019-10-23 9:00 ` [LTP] [PATCH v2 5/6] syscalls/quotactl04: add project quota test for non-xfs filesystem Yang Xu
2019-10-24 8:14 ` Jan Kara
2019-10-24 9:55 ` Yang Xu
2019-10-23 9:00 ` [LTP] [PATCH v2 6/6] syscalls/quotactl05: add project quota test for xfs filesystem Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120170948.GA7010@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox