From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/5] syscalls/quotactl01: Add Q_GETNEXTQUOTA test
Date: Thu, 21 Nov 2019 06:10:22 +0100 [thread overview]
Message-ID: <20191121051022.GA59487@x230> (raw)
In-Reply-To: <efb495a4-1071-68fd-d5a2-7597646228e1@cn.fujitsu.com>
Hi Xu,
> > + general question: do we want always test against kernel headers or libc
> > headers? Libc is often outdated, so mostly it'd be our fallback to be tested.
> > Ideally both kernel and libc header should be tested, but that's not easily
> > achievable.
> IMHO, We often test libc and it usually includes kernel headers ie.
> <sys/quota.h> <sys/prctl.h>. I perfet to check one except that glibc and
> kernel they have themselves implementation . If the struct or variable is
> not defined, we can define it in ltp lapi headers. Then we can avoid build
> error and increase coverage(because kernel may implement it).
Yep. I'm ok with using libc headers (increased coverage), but we need good
checks anyway for other libc (at least for musl; bionic also like glibc uses
internally kernel headers, uclibc-ng usually embeds kernel header parts and
strives to be glibc compatible anyway).
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-21 5:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 9:13 [LTP] [PATCH v4 0/5] optimize quotactl test code Yang Xu
2019-11-20 9:13 ` [LTP] [PATCH v4 1/5] syscalls/quotactl01: Add Q_GETNEXTQUOTA test Yang Xu
2019-11-20 15:12 ` Petr Vorel
2019-11-20 15:16 ` Petr Vorel
2019-11-21 3:37 ` Yang Xu
2019-11-21 5:10 ` Petr Vorel [this message]
2019-11-21 7:07 ` Yang Xu
2019-11-21 8:21 ` Petr Vorel
2019-11-21 9:01 ` Yang Xu
2019-11-21 2:29 ` Yang Xu
2019-11-21 5:45 ` Petr Vorel
2019-11-21 7:45 ` Yang Xu
2019-11-21 8:32 ` Petr Vorel
2019-11-21 8:38 ` Yang Xu
2019-11-21 9:01 ` Jan Stancek
2019-11-21 10:30 ` Petr Vorel
2019-11-21 11:08 ` Jan Stancek
2019-11-21 15:19 ` Petr Vorel
2019-11-20 9:13 ` [LTP] [PATCH v4 2/5] syscalls/quotactl02: Add Q_XGETQSTATV test and group quota tests Yang Xu
2019-11-20 9:13 ` [LTP] [PATCH v4 3/5] syscalls/quotactl04: add project quota test for non-xfs filesystem Yang Xu
2019-11-20 9:13 ` [LTP] [PATCH v4 4/5] syscalls/quotactl05: add project quota test on xfs filesystem Yang Xu
2019-11-20 9:13 ` [LTP] [PATCH v4 5/5] syscalls/quotactl06: Add new error testcase Yang Xu
2019-11-21 17:01 ` [LTP] [PATCH v4 0/5] optimize quotactl test code Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121051022.GA59487@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox