From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] memcg_lib/memcg_process: Better synchronization of signal USR1
Date: Thu, 21 Nov 2019 19:34:01 +0100 [thread overview]
Message-ID: <20191121183401.GA20889@dell5510> (raw)
In-Reply-To: <365bdf26-4e52-2159-17cd-52f2fb22e7fd@jv-coder.de>
Hi Joerg,
> > diff --git a/testcases/kernel/controllers/memcg/functional/memcg_lib.sh b/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
> > index aadaae4d2..7440e1eee 100755
> > --- a/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
> > +++ b/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
> > @@ -124,6 +124,7 @@ signal_memcg_process()
> > local usage_start=$(cat ${path}memory.usage_in_bytes)
> > kill -s USR1 $pid 2> /dev/null
> > + TST_CHECKPOINT_WAIT 1
> Actually this does not work like this, because some of the
> tests trigger the oom killer and TEST_CHECKPOINT_WAIT calling
> tst_checkpoint uses ROD. Is it ok to directly call
> tst_checkpoint wait 10000 "1"
> and ignore the result here?
> BTW: Is there no such thing like TST_CHECKPOINT in the new
> shell test library?
No, there is no support for TST_CHECKPOINT in shell.
To be honest I have no idea how to implement it.
It could be done in some form of checking some file content and in a loop and
sleep in the meantime (ineffective), but sync between C and shell API is IMHO
not possible.
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-21 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 7:36 [LTP] [PATCH] memcg_lib/memcg_process: Better synchronization of signal USR1 Joerg Vehlow
2019-11-06 8:33 ` Joerg Vehlow
2019-11-21 18:34 ` Petr Vorel [this message]
2019-11-25 13:14 ` Cyril Hrubis
2019-11-25 14:28 ` Petr Vorel
2019-11-25 13:29 ` Cyril Hrubis
2019-11-25 13:48 ` Joerg Vehlow
2019-11-25 15:32 ` Cyril Hrubis
2019-11-26 5:08 ` Joerg Vehlow
2019-11-26 12:10 ` Cyril Hrubis
2019-11-26 12:39 ` Joerg Vehlow
2019-11-27 7:41 ` Joerg Vehlow
2019-12-03 15:12 ` Cyril Hrubis
2019-12-06 6:24 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121183401.GA20889@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox