From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] memcg_lib/memcg_process: Better synchronization of signal USR1
Date: Mon, 25 Nov 2019 14:29:57 +0100 [thread overview]
Message-ID: <20191125132957.GC8703@rei.lan> (raw)
In-Reply-To: <365bdf26-4e52-2159-17cd-52f2fb22e7fd@jv-coder.de>
Hi!
> Actually this does not work like this, because some of the
> tests trigger the oom killer and TEST_CHECKPOINT_WAIT calling
> tst_checkpoint uses ROD. Is it ok to directly call
>
> tst_checkpoint wait 10000 "1"
>
> and ignore the result here?
Wouldn't that delay the test for too long?
The default timeout for checkpoints is probably too big.
This problem is quite tricky to get right I guess. Maybe we can watch
/proc/[pid]/statm for increase data + stack memory.
> BTW: Is there no such thing like TST_CHECKPOINT in the new
> shell test library?
It does not seem to be there, but these shell functions are just
wrappers that do check the tst_checkpoint return value, which would be
fairly easy to add.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-11-25 13:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 7:36 [LTP] [PATCH] memcg_lib/memcg_process: Better synchronization of signal USR1 Joerg Vehlow
2019-11-06 8:33 ` Joerg Vehlow
2019-11-21 18:34 ` Petr Vorel
2019-11-25 13:14 ` Cyril Hrubis
2019-11-25 14:28 ` Petr Vorel
2019-11-25 13:29 ` Cyril Hrubis [this message]
2019-11-25 13:48 ` Joerg Vehlow
2019-11-25 15:32 ` Cyril Hrubis
2019-11-26 5:08 ` Joerg Vehlow
2019-11-26 12:10 ` Cyril Hrubis
2019-11-26 12:39 ` Joerg Vehlow
2019-11-27 7:41 ` Joerg Vehlow
2019-12-03 15:12 ` Cyril Hrubis
2019-12-06 6:24 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125132957.GC8703@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox