public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Unshare KSM pages before setting max_page_sharing
Date: Mon, 2 Dec 2019 04:29:36 +0100	[thread overview]
Message-ID: <20191202032936.GA32335@dell5510> (raw)
In-Reply-To: <20191128163147.4377-1-mdoucha@suse.cz>

Hi Martin,

> Setting max_page_sharing is possible only when there are no KSM shared pages
> in the system. Otherwise writing to max_page_sharing SysFS file will fail
> with EBUSY.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Good catch!

BTW at least ksm01 will fail on VM host with running VMs,
but that's another story not related to this patch.

mem.c:251: FAIL: pages_shared is not 1 but 3629.
mem.c:251: FAIL: pages_sharing is not 98302 but 113789.
mem.c:251: FAIL: pages_volatile is not 0 but 12.
mem.c:251: FAIL: pages_unshared is not 1 but 48519.

Kind regards,
Petr

  parent reply	other threads:[~2019-12-02  3:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 16:31 [LTP] [PATCH] Unshare KSM pages before setting max_page_sharing Martin Doucha
2019-11-29  6:49 ` Li Wang
2019-12-02  3:29 ` Petr Vorel [this message]
2019-12-02  3:57   ` Li Wang
2019-12-04  9:07   ` Martin Doucha
2019-12-04 10:46     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202032936.GA32335@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox