public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cpuhotplug05.sh: Rewrite test case
Date: Mon, 9 Dec 2019 22:06:59 +0100	[thread overview]
Message-ID: <20191209210659.GA3820@dell5510> (raw)
In-Reply-To: <8f5e7d2a-34a8-5d2a-658c-a1f535fd1cc7@suse.cz>

Hi,

> On 12/9/19 4:13 AM, Xiao Yang wrote:
> >> Your new scenario has two problems:

> >> - You have to run at least two test loops to verify that reactivating a
> >> CPU doesn't break /proc/stat entries.

> > I think running cpuhotplug05.sh with -i 2 can verfiy this point.

> > Perhaps we can add -i option to runtest/cpuhotplug, or do you prefer to
> > keep the original scenario?

> I'd prefer keeping the original scenario (with your version of cleanup).
> Running extra iterations of the same test should not be required to get
> the full intended test coverage.
Agree with Martin. Yang, could you, please, send new version, where you keep it?


Kind regards,
Petr

  reply	other threads:[~2019-12-09 21:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 10:19 [LTP] [PATCH] cpuhotplug05.sh: Rewrite test case Xiao Yang
2019-12-04 15:11 ` Martin Doucha
2019-12-09  3:13   ` Xiao Yang
2019-12-09 12:50     ` Martin Doucha
2019-12-09 21:06       ` Petr Vorel [this message]
2019-12-10  1:37         ` Xiao Yang
2019-12-10  8:23           ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209210659.GA3820@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox