From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] network/iptables: add new test for iptables-tranlsate and nft
Date: Thu, 19 Dec 2019 08:08:45 +0100 [thread overview]
Message-ID: <20191219070845.GA25978@dell5510> (raw)
In-Reply-To: <853a8441-efc3-03e2-4889-1421cbe976b5@oracle.com>
Hi Alexey,
> > BTW even more setup could be moved into iptables_lib.sh.
> > If you like this change, I can push it.
> No objections. I thought it is better to keep these TST_*
> variables per test, in the header, rather than searching
> in the lib... but looks like it might save some duplication.
The main reason for me to move TST_* variables into library is to keep code
together, where it's used.
The downside of it is that these variables may be accidentally overwritten by
setup in test. That's why I used default values, which can be overwritten in
if-lib.sh.
I'll send a patch, feel free to not ack that (agree, that it's a syntax
optimization, the test itself is what matters).
Kind regards,
Petr
prev parent reply other threads:[~2019-12-19 7:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 17:19 [LTP] [PATCH v2 1/2] network/iptables: reduce ping timeouts Alexey Kodanev
2019-12-17 17:19 ` [LTP] [PATCH v2 2/2] network/iptables: add new test for iptables-tranlsate and nft Alexey Kodanev
2019-12-18 8:44 ` Petr Vorel
2019-12-18 14:46 ` Alexey Kodanev
2019-12-18 15:28 ` Petr Vorel
2019-12-18 15:53 ` Alexey Kodanev
2019-12-19 7:08 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219070845.GA25978@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox